Skip to content

Commit

Permalink
fix(module-federation): handle tspath mappings with /* wildcard #26765
Browse files Browse the repository at this point in the history
  • Loading branch information
Coly010 committed Jul 26, 2024
1 parent 45c458e commit d6d44e3
Showing 1 changed file with 22 additions and 2 deletions.
24 changes: 22 additions & 2 deletions packages/webpack/src/utils/module-federation/share.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,12 @@ export function shareWorkspaceLibraries(
return {
getAliases: () =>
pathMappings.reduce(
(aliases, library) => ({ ...aliases, [library.name]: library.path }),
(aliases, library) => ({
...aliases,
// If the library path ends in a wildcard, remove it as webpack can't handle this in resolve.alias
// e.g. path/to/my/lib/* -> path/to/my/lib
[library.name]: library.path.replace(/\/\*$/, ''),
}),
{}
),
getLibraries: (
Expand Down Expand Up @@ -145,7 +150,22 @@ export function shareWorkspaceLibraries(
for (const library of pathMappings) {
const libFolder = normalize(dirname(library.path));
if (!from.startsWith(libFolder) && to.startsWith(libFolder)) {
req.request = library.name;
const newReq = library.name.endsWith('/*')
? /**
* req usually is in the form of "../../../path/to/file"
* library.path is usually in the form of "/Users/username/path/to/Workspace/path/to/library"
*
* When a wildcard is used in the TS path mappings, we want to get everything after the import to
* re-route the request correctly inline with the webpack resolve.alias
*/
join(
library.name,
req.request.split(
library.path.replace(workspaceRoot, '').replace('/*', '')
)[1]
)
: library.name;
req.request = newReq;
}
}
}),
Expand Down

0 comments on commit d6d44e3

Please sign in to comment.