Skip to content

Commit

Permalink
chore(react-native): uncomment detox e2e test to build and test nativ…
Browse files Browse the repository at this point in the history
…e ios
  • Loading branch information
xiongemi committed Oct 4, 2021
1 parent b79072a commit d60e996
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions e2e/detox/src/detox.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
runCLIAsync,
uniq,
getSelectedPackageManager,
killPorts,
} from '@nrwl/e2e/utils';

describe('Detox', () => {
Expand All @@ -31,7 +32,7 @@ describe('Detox', () => {

describe('React Native Detox MACOS-Tests', () => {
if (isOSX()) {
it('should build and test ios MACOS-Tests', async () => {
it('should build and test ios', async () => {
const appName = uniq('myapp');
runCLI(
`generate @nrwl/react-native:app ${appName} --e2eTestRunner=detox --linter=eslint`
Expand All @@ -41,8 +42,7 @@ describe('Detox', () => {
'Running target "build-ios" succeeded'
);

// comment out due to github issue that unable to build xcode error 12.5 https://github.com/facebook/react-native/issues/31480
/* expect(runCLI(`build-ios ${appName}-e2e --pod`)).toContain(
expect(runCLI(`build-ios ${appName}-e2e --pod`)).toContain(
'Running target "build-ios" succeeded'
);
expect(
Expand All @@ -52,7 +52,6 @@ describe('Detox', () => {
).toContain('Running target "test-ios" succeeded');

await killPorts(8081); // kill the port for the serve command
*/
}, 1000000);
}
});
Expand Down

0 comments on commit d60e996

Please sign in to comment.