fix(core): ignore dependencies from non-index root files for create-p…

…ackage-json
nrwl · Jul 3, 2023 · d399c2c · d399c2c
1 parent 50d01d1
commit d399c2c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/packages/js/src/utils/package-json/update-package-json.spec.ts b/packages/js/src/utils/package-json/update-package-json.spec.ts
@@ -290,7 +290,7 @@ describe('updatePackageJson', () => {
   const fileMap = {
     '@org/lib1': [
       {
-        file: 'test.ts',
+        file: 'libs/lib1/src/test.ts',
         hash: '',
         deps: ['npm:external1', 'npm:external2'],
       },

diff --git a/packages/nx/src/plugins/js/package-json/create-package-json.ts b/packages/nx/src/plugins/js/package-json/create-package-json.ts
@@ -16,6 +16,7 @@ import {
 import { readNxJson } from '../../../config/configuration';
 import { readProjectFileMapCache } from '../../../project-graph/nx-deps-cache';
 import { join } from 'path';
+import { file } from 'tmp';
 
 interface NpmDeps {
   readonly dependencies: Record<string, string>;
@@ -222,6 +223,17 @@ export function findProjectsNpmDependencies(
   return npmDeps;
 }
 
+// this function checks if the file path in in the root and not index.ts file
+// these files are likely configuration files
+function isIndexOrNonRoot(filePath: string, root: string): boolean {
+  if (filePath.slice(root.length + 1).includes('/')) {
+    return true;
+  }
+  return ['index.ts', 'index.js', 'index.jsx', 'index.tsx'].some(
+    (f) => `${root}/${f}` === filePath
+  );
+}
+
 function findAllNpmDeps(
   projectFileMap: ProjectFileMap,
   projectNode: ProjectGraphProjectNode,
@@ -240,7 +252,7 @@ function findAllNpmDeps(
     projectNode.data.root,
     projectFileMap[projectNode.name] || [],
     rootPatterns ?? dependencyPatterns
-  );
+  ).filter((f) => isIndexOrNonRoot(f.file, projectNode.data.root));
 
   const projectDependencies = new Set<string>();