fix(web): readd skipTypeField

previously removed and needs to be readded back since nx should always support esm modules with cjs dependencies. Forcing modern libraries to be not in esm format isn't good practice
nrwl · Jun 18, 2023 · d34674a · d34674a
1 parent 1fda800
commit d34674a
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/docs/generated/packages/rollup/executors/rollup.json b/docs/generated/packages/rollup/executors/rollup.json
@@ -169,6 +169,11 @@
         "type": "boolean",
         "description": "Whether to skip TypeScript type checking.",
         "default": false
+      },
+      "skipTypeField": {
+        "type": "boolean",
+        "description": "Prevent type field from being added to package json. Use this if you have an esm library with common js imports.",
+        "default": false
       }
     },
     "required": ["tsConfig", "main", "outputPath"],

diff --git a/packages/rollup/src/executors/rollup/lib/update-package-json.ts b/packages/rollup/src/executors/rollup/lib/update-package-json.ts
@@ -45,8 +45,9 @@ export function updatePackageJson(
     packageJson.main = './index.cjs';
     exports['.']['require'] = './index.cjs';
   }
-
-  packageJson.type = options.format.includes('esm') ? 'module' : 'commonjs';
+  if (!options.skipTypeField) {
+    packageJson.type = options.format.includes('esm') ? 'module' : 'commonjs';
+  }
 
   // Support for older TS versions < 4.5
   packageJson.types = types;

diff --git a/packages/rollup/src/executors/rollup/schema.d.ts b/packages/rollup/src/executors/rollup/schema.d.ts
@@ -33,4 +33,5 @@ export interface RollupExecutorOptions {
   generateExportsField?: boolean;
   skipTypeCheck?: boolean;
   babelUpwardRootMode?: boolean;
+  skipTypeField?: boolean;
 }
diff --git a/packages/rollup/src/executors/rollup/schema.json b/packages/rollup/src/executors/rollup/schema.json
@@ -156,6 +156,11 @@
       "type": "boolean",
       "description": "Whether to skip TypeScript type checking.",
       "default": false
+    },
+    "skipTypeField": {
+      "type": "boolean",
+      "description": "Prevent type field from being added to package json. Use this if you have an esm library with common js imports.",
+      "default": false
     }
   },
   "required": ["tsConfig", "main", "outputPath"],