fix(core): task runner parallel should read from taskRunnerOptions (#…

…16707)
nrwl · May 2, 2023 · d084e67 · d084e67 · vercel · May 2, 2023
1 parent ccf6759
commit d084e67
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 25 deletions.
diff --git a/packages/nx/src/tasks-runner/default-tasks-runner.ts b/packages/nx/src/tasks-runner/default-tasks-runner.ts
@@ -50,7 +50,8 @@ export const defaultTasksRunner: TasksRunner<
   } else if (
     (options as any)['parallel'] === 'true' ||
     (options as any)['parallel'] === true ||
-    (options as any)['parallel'] === undefined
+    (options as any)['parallel'] === undefined ||
+    (options as any)['parallel'] === ''
   ) {
     (options as any)['parallel'] = Number((options as any)['maxParallel'] || 3);
   }

diff --git a/packages/nx/src/utils/command-line-utils.spec.ts b/packages/nx/src/utils/command-line-utils.spec.ts
@@ -20,7 +20,6 @@ describe('splitArgs', () => {
       base: 'sha1',
       head: 'sha2',
       skipNxCache: false,
-      parallel: 3,
     });
   });
 
@@ -52,7 +51,6 @@ describe('splitArgs', () => {
     ).toEqual({
       base: 'main',
       skipNxCache: false,
-      parallel: 3,
     });
   });
 
@@ -70,7 +68,6 @@ describe('splitArgs', () => {
     ).toEqual({
       base: 'develop',
       skipNxCache: false,
-      parallel: 3,
     });
   });
 
@@ -88,7 +85,6 @@ describe('splitArgs', () => {
     ).toEqual({
       base: 'main',
       skipNxCache: false,
-      parallel: 3,
     });
   });
 
@@ -178,7 +174,6 @@ describe('splitArgs', () => {
         {} as any
       ).nxArgs
     ).toEqual({
-      parallel: 3,
       projects: ['aaa', 'bbb'],
       skipNxCache: false,
     });
@@ -205,7 +200,6 @@ describe('splitArgs', () => {
           base: 'envVarSha1',
           head: 'envVarSha2',
           skipNxCache: false,
-          parallel: 3,
         });
 
         expect(
@@ -223,7 +217,6 @@ describe('splitArgs', () => {
           base: 'envVarSha1',
           head: 'directlyOnCommandSha1',
           skipNxCache: false,
-          parallel: 3,
         });
 
         expect(
@@ -241,7 +234,6 @@ describe('splitArgs', () => {
           base: 'directlyOnCommandSha2',
           head: 'envVarSha2',
           skipNxCache: false,
-          parallel: 3,
         });
       }
     );
@@ -388,20 +380,6 @@ describe('splitArgs', () => {
       expect(parallel).toEqual(5);
     });
 
-    it('should default to 3 when not specified', () => {
-      const parallel = splitArgsIntoNxArgsAndOverrides(
-        {
-          $0: '',
-          __overrides_unparsed__: [],
-        },
-        'affected',
-        {} as any,
-        {} as any
-      ).nxArgs.parallel;
-
-      expect(parallel).toEqual(3);
-    });
-
     it('should default to 3 when used with no value specified', () => {
       const parallel = splitArgsIntoNxArgsAndOverrides(
         {

diff --git a/packages/nx/src/utils/command-line-utils.ts b/packages/nx/src/utils/command-line-utils.ts
@@ -188,8 +188,7 @@ export function splitArgsIntoNxArgsAndOverrides(
   } else if (
     args['parallel'] === 'true' ||
     args['parallel'] === true ||
-    args['parallel'] === '' ||
-    args['parallel'] === undefined
+    args['parallel'] === ''
   ) {
     nxArgs['parallel'] = Number(
       nxArgs['maxParallel'] || nxArgs['max-parallel'] || 3