Skip to content

Commit

Permalink
fix(nextjs): For serve executor keepAliveTimeout should be camelCased
Browse files Browse the repository at this point in the history
closes: #17765
  • Loading branch information
ndcunningham committed Jun 26, 2023
1 parent 77430cb commit ceee464
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
6 changes: 5 additions & 1 deletion packages/js/src/executors/node/node.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,11 @@ export async function* nodeExecutor(
const outputFileName =
buildOptions.outputFileName ?? `${path.parse(buildOptions.main).name}.js`;

const fileToRun = join(context.root, buildOptions.outputPath, outputFileName);
const fileToRun = join(
context.root,
buildOptions.outputPath,
buildOptions.outputFileName ?? 'main.js'
);
const tasks: ActiveTask[] = [];
let currentTask: ActiveTask = null;

Expand Down
6 changes: 5 additions & 1 deletion packages/next/src/executors/server/server.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ export default async function* serveExecutor(
// Setting port that the custom server should use.
process.env.PORT = `${options.port}`;

const args = createCliOptions({ port, keepAliveTimeout, hostname });
const args = createCliOptions({ port, hostname });

if (keepAliveTimeout && !options.dev) {
args.push('--keepAliveTimeout', `${keepAliveTimeout}`);
}

const nextDir = resolve(context.root, buildOptions.outputPath);

Expand Down

0 comments on commit ceee464

Please sign in to comment.