Skip to content

Commit

Permalink
fix(module-federation): dynamic remotes external to workspace should …
Browse files Browse the repository at this point in the history
…be skipped correctly #26551 (#26692)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
Module Federation utils were not checking if the remotes defined
dynamically in the `module-federation.manifest.json` were in the project
graph.



## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Check that the dynamic remotes exist in the project graph before trying
to do work with them

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #26551
  • Loading branch information
Coly010 authored Jun 26, 2024
1 parent d3383ca commit ce3f7f4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export function getRemotes(
);

const knownDynamicRemotes = dynamicRemotes.filter(
(r) => !remotesToSkip.has(r)
(r) => !remotesToSkip.has(r) && context.projectGraph.nodes[r]
);

logger.info(
Expand Down

0 comments on commit ce3f7f4

Please sign in to comment.