Skip to content

Commit

Permalink
fix(linter): remove extend of @angular-eslint/recommended--extra conf…
Browse files Browse the repository at this point in the history
…ig (#18465)
  • Loading branch information
miluoshi authored Jan 29, 2024
1 parent f9009e9 commit bb3cf3a
Showing 1 changed file with 1 addition and 17 deletions.
18 changes: 1 addition & 17 deletions packages/eslint-plugin/src/configs/angular.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
import type AngularEslintPlugin from '@angular-eslint/eslint-plugin';

let angularEslintPlugin: typeof AngularEslintPlugin;
try {
angularEslintPlugin = require('@angular-eslint/eslint-plugin');
} catch {}

/**
* This configuration is intended to be applied to ALL .ts files in Angular
* projects within an Nx workspace.
Expand All @@ -23,16 +16,7 @@ export default {
node: true,
},
plugins: ['@angular-eslint'],
extends: [
'plugin:@angular-eslint/recommended',
/**
* TODO: Consider dropping this extends and explicitly carrying over rules we care about
* into our typescript preset in v13
*/
...(angularEslintPlugin?.configs?.['recommended--extra']
? ['plugin:@angular-eslint/recommended--extra']
: []),
],
extends: ['plugin:@angular-eslint/recommended'],
parserOptions: {
// Unset the default value for parserOptions.project that is found in earlier versions of @angular-eslint
project: [],
Expand Down

0 comments on commit bb3cf3a

Please sign in to comment.