Skip to content

Commit

Permalink
feat(core): support third-party packages for surgical hashTarget hash…
Browse files Browse the repository at this point in the history
…ing (#16903)
  • Loading branch information
meeroslav authored May 11, 2023
1 parent 9d74b58 commit b55aa8f
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions packages/nx/src/hasher/hasher.ts
Original file line number Diff line number Diff line change
Expand Up @@ -385,13 +385,9 @@ class TaskHasher {
return;
}

// we can only vouch for @nrwl packages's executors
// if it's "run commands" we skip traversing since we have no info what this command depends on
// for everything else we take the hash of the @nrwl package dependency tree
if (
target.executor.startsWith(`@nrwl/`) ||
target.executor.startsWith(`@nx/`)
) {
// for everything else we take the hash of the executor package's dependency tree
if (!target.executor.startsWith(`nx:run-commands`)) {
const executorPackage = target.executor.split(':')[0];
const executorNode = `npm:${executorPackage}`;
if (this.projectGraph.externalNodes?.[executorNode]) {
Expand Down

1 comment on commit b55aa8f

@vercel
Copy link

@vercel vercel bot commented on b55aa8f May 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-dev-nrwl.vercel.app
nx.dev
nx-dev-git-master-nrwl.vercel.app
nx-five.vercel.app

Please sign in to comment.