Skip to content

Commit

Permalink
fix(react-native): fix android keystore not generated correctly (#17074)
Browse files Browse the repository at this point in the history
  • Loading branch information
xiongemi authored May 19, 2023
1 parent 4896126 commit b0b531a
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 12 deletions.
1 change: 1 addition & 0 deletions packages/devkit/src/utils/binary-extensions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ const binaryExtensions = new Set([
'.jpm',
'.jxr',
'.key',
'.keystore',
'.ktx',
'.lha',
'.lib',
Expand Down
10 changes: 0 additions & 10 deletions packages/react-native/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,6 @@
"options": {
"assets": [
"packages/react-native/*.md",
{
"input": "packages/react-native",
"glob": "**/files/**/.babelrc__tmpl__",
"output": "/"
},
{
"input": "packages/react-native",
"glob": "**/files/**/.babelrc.template",
Expand All @@ -26,11 +21,6 @@
"glob": "**/*.!(ts)",
"output": "/src"
},
{
"input": "packages/react-native",
"glob": "*.rb",
"output": "/"
},
{
"input": "packages/react-native",
"glob": "**/*.json",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import com.facebook.react.defaults.DefaultNewArchitectureEntryPoint;
import com.facebook.react.defaults.DefaultReactNativeHost;
import com.facebook.soloader.SoLoader;
import java.util.List;
import com.lugg.RNCConfig.RNCConfigPackage;

This comment has been minimized.

Copy link
@kevindice

kevindice May 24, 2023

@xiongemi Why is this removed here?

This comment has been minimized.

Copy link
@xiongemi

xiongemi May 24, 2023

Author Collaborator

this is removed due to react-native-config is removed from the default install library. for env variable, it is no longer default to use react-native-config. you are welcomed to use any library/stack. it is no longer locked to react-native-config.


public class MainApplication extends Application implements ReactApplication {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ buildscript {
minSdkVersion = 21
compileSdkVersion = 33
targetSdkVersion = 33
kotlinVersion = "1.7.21"
kotlinVersion = "1.8.20"

// We use NDK 23 which has both M1 support and is the side-by-side NDK version from AGP.
ndkVersion = "23.1.7779620"
Expand Down

1 comment on commit b0b531a

@vercel
Copy link

@vercel vercel bot commented on b0b531a May 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-dev-nrwl.vercel.app
nx.dev
nx-dev-git-master-nrwl.vercel.app
nx-five.vercel.app

Please sign in to comment.