fix(node): add default build configuration (#15542)

nrwl · Mar 8, 2023 · a69f8ab · a69f8ab
1 parent f7367ff
commit a69f8ab
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 10 deletions.
diff --git a/e2e/node/src/node-esbuild.test.ts b/e2e/node/src/node-esbuild.test.ts
@@ -27,7 +27,6 @@ describe('Node Applications + esbuild', () => {
     await runCLIAsync(`build ${app}`);
 
     checkFilesExist(`dist/apps/${app}/main.js`);
-    checkFilesExist(`dist/apps/${app}/main.js.map`);
     const result = execSync(`node dist/apps/${app}/main.js`, {
       cwd: tmpProjPath(),
     }).toString();

diff --git a/packages/node/src/generators/application/application.spec.ts b/packages/node/src/generators/application/application.spec.ts
@@ -49,6 +49,7 @@ describe('app', () => {
           build: {
             executor: '@nrwl/webpack:webpack',
             outputs: ['{options.outputPath}'],
+            defaultConfiguration: 'production',
             options: {
               target: 'node',
               compiler: 'tsc',
@@ -60,19 +61,20 @@ describe('app', () => {
               assets: ['my-node-app/src/assets'],
             },
             configurations: {
-              production: {
-                optimization: true,
-                extractLicenses: true,
-                inspect: false,
-              },
+              development: {},
+              production: {},
             },
           },
           serve: {
             executor: '@nrwl/js:node',
+            defaultConfiguration: 'development',
             options: {
               buildTarget: 'my-node-app:build',
             },
             configurations: {
+              development: {
+                buildTarget: 'my-node-app:build:development',
+              },
               production: {
                 buildTarget: 'my-node-app:build:production',
               },

diff --git a/packages/node/src/generators/application/application.ts b/packages/node/src/generators/application/application.ts
@@ -58,6 +58,7 @@ function getWebpackBuildConfig(
   return {
     executor: `@nrwl/webpack:webpack`,
     outputs: ['{options.outputPath}'],
+    defaultConfiguration: 'production',
     options: {
       target: 'node',
       compiler: 'tsc',
@@ -78,11 +79,9 @@ function getWebpackBuildConfig(
       ),
     },
     configurations: {
+      development: {},
       production: {
         ...(options.docker && { generateLockfile: true }),
-        optimization: true,
-        extractLicenses: true,
-        inspect: false,
       },
     },
   };
@@ -95,6 +94,7 @@ function getEsBuildConfig(
   return {
     executor: '@nrwl/esbuild:esbuild',
     outputs: ['{options.outputPath}'],
+    defaultConfiguration: 'production',
     options: {
       platform: 'node',
       outputPath: joinPathFragments(
@@ -117,9 +117,14 @@ function getEsBuildConfig(
       },
     },
     configurations: {
+      development: {},
       production: {
         ...(options.docker && { generateLockfile: true }),
-        esbuildOptions: { sourcemap: false },
+        esbuildOptions: {
+          sourcemap: false,
+          // Generate CJS files as .js so imports can be './foo' rather than './foo.cjs'.
+          outExtension: { '.js': '.js' },
+        },
       },
     },
   };
@@ -128,10 +133,14 @@ function getEsBuildConfig(
 function getServeConfig(options: NormalizedSchema): TargetConfiguration {
   return {
     executor: '@nrwl/js:node',
+    defaultConfiguration: 'development',
     options: {
       buildTarget: `${options.name}:build`,
     },
     configurations: {
+      development: {
+        buildTarget: `${options.name}:build:development`,
+      },
       production: {
         buildTarget: `${options.name}:build:production`,
       },