fix(core): hide duplicate log entry when displaying generator help

nrwl · Apr 17, 2023 · a55b714 · a55b714
1 parent 4ee1ba5
commit a55b714
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/nx/src/command-line/generate.ts b/packages/nx/src/command-line/generate.ts
@@ -333,7 +333,7 @@ export async function generate(cwd: string, args: { [k: string]: any }) {
         ].join('/n')
       );
     }
-    if (!opts.quiet) {
+    if (!opts.quiet && !opts.help) {
       logger.info(
         `NX Generating ${opts.collectionName}:${normalizedGeneratorName}`
       );

diff --git a/packages/nx/src/utils/print-help.ts b/packages/nx/src/utils/print-help.ts
@@ -6,6 +6,7 @@ import { logger } from './logger';
 import { output } from './output';
 import { Schema } from './params';
 import { nxVersion } from './versions';
+import { readModulePackageJson } from './package-json';
 
 export function printHelp(
   header: string,
@@ -97,6 +98,11 @@ function generateGeneratorOverviewOutput({
     // The `:` char
     1;
 
+  let installedVersion: string;
+  try {
+    installedVersion = readModulePackageJson(pluginName).packageJson.version;
+  } catch {}
+
   ui.div(
     ...[
       {
@@ -107,9 +113,7 @@ function generateGeneratorOverviewOutput({
       {
         text:
           pluginName +
-          (pluginName.startsWith('@nx/') || pluginName.startsWith('@nrwl/')
-            ? chalk.dim(` (v${nxVersion})`)
-            : ''),
+          (installedVersion ? chalk.dim(` (v${installedVersion})`) : ''),
         padding: [1, 0, 0, 2],
       },
     ]