fix(react-native): remove listDevices default value for run-android (#…

…16410)
nrwl · Apr 19, 2023 · 9c9abaa · 9c9abaa · vercel · Apr 19, 2023
1 parent 1743ff1
commit 9c9abaa
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/docs/generated/packages/react-native/executors/run-android.json b/docs/generated/packages/react-native/executors/run-android.json
@@ -53,8 +53,7 @@
       },
       "listDevices": {
         "type": "boolean",
-        "description": "Lists all available Android devices and simulators and let you choose one to run the app",
-        "default": false
+        "description": "Lists all available Android devices and simulators and let you choose one to run the app"
       },
       "binaryPath": {
         "type": "string",
@@ -93,7 +92,6 @@
       "activeArchOnly": {
         "type": "boolean",
         "description": "Build native libraries only for the current device architecture for debug builds.",
-        "examples": ["x86_64", "arm64-v8a"],
         "default": false
       },
       "extraParams": {

diff --git a/packages/react-native/src/executors/run-android/run-android.impl.ts b/packages/react-native/src/executors/run-android/run-android.impl.ts
@@ -105,6 +105,6 @@ function createRunAndroidOptions(options: ReactNativeRunAndroidOptions) {
   return getCliOptions<ReactNativeRunAndroidOptions>(
     options,
     [...nxOptions, ...startOptions, ...deprecatedOptions],
-    ['appId', 'appIdSuffix']
+    ['appId', 'appIdSuffix', 'deviceId']
   );
 }
diff --git a/packages/react-native/src/executors/run-android/schema.json b/packages/react-native/src/executors/run-android/schema.json
@@ -53,8 +53,7 @@
     },
     "listDevices": {
       "type": "boolean",
-      "description": "Lists all available Android devices and simulators and let you choose one to run the app",
-      "default": false
+      "description": "Lists all available Android devices and simulators and let you choose one to run the app"
     },
     "binaryPath": {
       "type": "string",
@@ -95,7 +94,6 @@
     "activeArchOnly": {
       "type": "boolean",
       "description": "Build native libraries only for the current device architecture for debug builds.",
-      "examples": ["x86_64", "arm64-v8a"],
       "default": false
     },
     "extraParams": {