fix(angular): target correct versions of ng-packagr to create stylesh…

…eet worker synchronously (#22485)
nrwl · Mar 25, 2024 · 9bfdf89 · 9bfdf89
1 parent 54d4780
commit 9bfdf89
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/packages/angular/src/executors/utilities/ng-packagr/stylesheet-processor.di.ts b/packages/angular/src/executors/utilities/ng-packagr/stylesheet-processor.di.ts
@@ -1,6 +1,5 @@
 import type { FactoryProvider } from 'injection-js';
 import { STYLESHEET_PROCESSOR_TOKEN } from 'ng-packagr/lib/styles/stylesheet-processor.di';
-import { gte, lt } from 'semver';
 import { getInstalledPackageVersionInfo } from '../angular-version-utils';
 import {
   AsyncStylesheetProcessor,
@@ -13,7 +12,7 @@ export const STYLESHEET_PROCESSOR: FactoryProvider = {
     const { version: ngPackagrVersion } =
       getInstalledPackageVersionInfo('ng-packagr');
 
-    return lt(ngPackagrVersion, '17.2.0') || gte(ngPackagrVersion, '17.3.0')
+    return ngPackagrVersion !== '17.2.0'
       ? StylesheetProcessor
       : AsyncStylesheetProcessor;
   },

diff --git a/packages/angular/src/executors/utilities/ng-packagr/stylesheet-processor.ts b/packages/angular/src/executors/utilities/ng-packagr/stylesheet-processor.ts
@@ -129,10 +129,10 @@ export class StylesheetProcessor {
 }
 
 /**
- * This class is used when ng-packagr version is greater than or equal to 17.2.0 and less than 17.3.0.
- * The async `loadPostcssConfiguration` function introduced in ng-packagr 17.2.x causes a memory leak
- * due to multiple workers being created. We must keep this class to support any workspace that might
- * be using ng-packagr 17.2.x where that function need to be awaited.
+ * This class is used when ng-packagr version is 17.2.0. The async `loadPostcssConfiguration` function
+ * introduced in ng-packagr 17.2.0 causes a memory leak due to multiple workers being created. We must
+ * keep this class to support any workspace that might be using ng-packagr 17.2.0 where that function
+ * need to be awaited.
  */
 export class AsyncStylesheetProcessor {
   private renderWorker: typeof Piscina | undefined;
@@ -199,7 +199,7 @@ export class AsyncStylesheetProcessor {
     const { version: ngPackagrVersion } =
       getInstalledPackageVersionInfo('ng-packagr');
     let postcssConfiguration: PostcssConfiguration | undefined;
-    if (gte(ngPackagrVersion, '17.2.0')) {
+    if (ngPackagrVersion === '17.2.0') {
       const { loadPostcssConfiguration } = await import(
         'ng-packagr/lib/styles/postcss-configuration'
       );