fix(testing): getJestProjectsAsync no longer duplicates project paths

nrwl · Oct 4, 2024 · 8f565db · 8f565db
1 parent f743808
commit 8f565db
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/packages/jest/src/utils/config/get-jest-projects.spec.ts b/packages/jest/src/utils/config/get-jest-projects.spec.ts
@@ -462,10 +462,7 @@ describe('getJestProjectsAsync', () => {
         },
       },
     });
-    const expectedResults = [
-      '<rootDir>/projects/test-1',
-      '<rootDir>/projects/test-1/jest1.config.ts',
-    ];
+    const expectedResults = ['<rootDir>/projects/test-1/jest1.config.ts'];
     expect(await getJestProjectsAsync()).toEqual(expectedResults);
   });
 

diff --git a/packages/jest/src/utils/config/get-jest-projects.ts b/packages/jest/src/utils/config/get-jest-projects.ts
@@ -4,7 +4,7 @@ import {
   type TargetConfiguration,
 } from '@nx/devkit';
 import { readWorkspaceConfig } from 'nx/src/project-graph/file-utils';
-import { join } from 'path';
+import { join, parse } from 'path';
 import * as yargs from 'yargs-parser';
 
 function getJestConfigProjectPath(projectJestConfigPath: string): string {
@@ -120,9 +120,20 @@ export async function getJestProjectsAsync() {
     }
   }
 
+  removeDuplicates(jestConfigurations);
   return Array.from(jestConfigurations);
 }
 
+// If two paths result in same project, prefer the more specific path.
+// e.g. <rootDir>/demo/jest.config.js over <rootDir>/demo
+function removeDuplicates(configs: Set<string>): void {
+  configs.forEach((config) => {
+    const { dir, ext } = parse(config);
+    // If the directory has been added previously, remove it and keep the current, more specific path.
+    if (ext) configs.delete(dir);
+  });
+}
+
 function collectJestConfigFromJestExecutor(
   targetConfiguration: TargetConfiguration,
   jestConfigurations: Set<string>