Skip to content

Commit

Permalink
chore(repo): re-enable macos e2e caching (#18382)
Browse files Browse the repository at this point in the history
  • Loading branch information
FrozenPandaz authored Jul 31, 2023
1 parent 8adee8e commit 8d5a160
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ jobs:
executor: macos
environment:
NX_E2E_CI_CACHE_KEY: e2e-circleci-macos
NX_DAEMON: 'true'
NX_DAEMON: 'false' # TODO: Fix the hashing issue and re-enable this
NX_PERF_LOGGING: 'false'
SELECTED_PM: 'npm' # explicitly define npm for macOS tests
NX_SKIP_NX_CACHE: 'true' # TODO: Figure out what is going on with the cache and renable it
Expand Down
1 change: 0 additions & 1 deletion nx.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
"tasksRunnerOptions": {
"default": {
"runner": "nx-cloud",
"nativeWatcher": true,
"options": {
"accessToken": "NDg1NTA3MTAtOGFmZC00YmIwLTk2Y2MtOTkzNzc4ZTczYTlkfHJlYWQtb25seQ==",
"cacheableOperations": [
Expand Down
1 change: 0 additions & 1 deletion scripts/copy-local-native.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ const p = process.argv[2];
const nativeFiles = glob.sync(`packages/${p}/**/*.node`);

nativeFiles.forEach((file) => {
console.log('COPY', file, '=>', `build/${file}`);
fs.copyFileSync(file, `build/${file}`);
});
3 changes: 0 additions & 3 deletions scripts/nx-release.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,6 @@ function hideFromGitIndex(uncommittedFiles: string[]) {
execSync(buildCommand, {
stdio: [0, 1, 2],
});
execSync(`ls -lah build/packages/nx/src/native`, {
stdio: [0, 1, 2],
});

if (options.local) {
updateLernaJsonVersion(currentLatestVersion);
Expand Down

1 comment on commit 8d5a160

@vercel
Copy link

@vercel vercel bot commented on 8d5a160 Jul 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nx-dev – ./

nx-dev-git-master-nrwl.vercel.app
nx-dev-nrwl.vercel.app
nx.dev
nx-five.vercel.app

Please sign in to comment.