Skip to content

Commit

Permalink
fix(core): remove v8-compile-cache (#20454)
Browse files Browse the repository at this point in the history
  • Loading branch information
FrozenPandaz authored Nov 28, 2023
1 parent e19d513 commit 8c14244
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 20 deletions.
19 changes: 0 additions & 19 deletions packages/nx/bin/nx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,25 +53,6 @@ function main() {
process.env.NX_DAEMON = 'false';
require('nx/src/command-line/nx-commands').commandsObject.argv;
} else {
// v8-compile-cache doesn't support ESM. Attempting to import ESM
// with it enabled results in an error that reads "Invalid host options".
//
// Angular CLI, and prettier both use ESM so we need to disable it in these cases.
if (
workspace &&
workspace.type === 'nx' &&
![
'format',
'format:check',
'format:write',
'g',
'generate',
'release',
].some((cmd) => process.argv[2] === cmd)
) {
require('v8-compile-cache');
}

if (!daemonClient.enabled() && workspace !== null) {
setupWorkspaceContext(workspace.dir);
}
Expand Down
1 change: 0 additions & 1 deletion packages/nx/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"tmp": "~0.2.1",
"tsconfig-paths": "^4.1.2",
"tslib": "^2.3.0",
"v8-compile-cache": "2.3.0",
"yargs": "^17.6.2",
"yargs-parser": "21.1.1",
"node-machine-id": "1.1.12"
Expand Down

0 comments on commit 8c14244

Please sign in to comment.