Skip to content

Commit

Permalink
chore(core): update devcontainer (#23479)
Browse files Browse the repository at this point in the history
Updates the devcontainer so that it has the correct version of pnpm

Fixes #20419
  • Loading branch information
isaacplmann authored May 21, 2024
1 parent 08ef0e4 commit 89fdd42
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
7 changes: 7 additions & 0 deletions .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
FROM mcr.microsoft.com/devcontainers/typescript-node:20-bullseye

# Update the underlying (Debian) OS, to make sure we have the latest security patches and libraries like 'GLIBC'
RUN sudo apt-get update && sudo apt-get -y upgrade

# Update pnpm
RUN npm install -g [email protected]
5 changes: 4 additions & 1 deletion .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@
{
"name": "NxDevContainer",
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
"image": "mcr.microsoft.com/devcontainers/typescript-node:20-bullseye",
"build": {
// Path is relative to the devcontainer.json file.
"dockerfile": "Dockerfile"
},
"features": {
"ghcr.io/devcontainers/features/rust:1": {}
},
Expand Down
6 changes: 0 additions & 6 deletions .devcontainer/postCreateCommand.sh
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
#!/bin/sh

# Update the underlying (Debian) OS, to make sure we have the latest security patches and libraries like 'GLIBC'
sudo apt-get update && sudo apt-get -y upgrade

# Update pnpm
#npm install -g pnpm

# Install dependencies
pnpm install --frozen-lockfile

0 comments on commit 89fdd42

Please sign in to comment.