fix(bundling): check for browserslist when setting terser ecma #17620 (…

…#17708)
nrwl · Jun 21, 2023 · 6305e7f · 6305e7f · vercel · Jun 21, 2023
1 parent e9f4f8a
commit 6305e7f
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 5 deletions.
diff --git a/packages/webpack/package.json b/packages/webpack/package.json
@@ -32,6 +32,7 @@
     "@babel/core": "^7.15.0",
     "autoprefixer": "^10.4.9",
     "babel-loader": "^9.1.2",
+    "browserslist": "^4.21.4",
     "chalk": "^4.1.0",
     "chokidar": "^3.5.1",
     "copy-webpack-plugin": "^10.2.4",

diff --git a/packages/webpack/src/utils/with-nx.ts b/packages/webpack/src/utils/with-nx.ts
@@ -1,19 +1,43 @@
 import * as path from 'path';
-import { Configuration, WebpackPluginInstance, ProgressPlugin } from 'webpack';
+import { join } from 'path';
+import { Configuration, ProgressPlugin, WebpackPluginInstance } from 'webpack';
 import { ExecutorContext } from 'nx/src/config/misc-interfaces';
 import { TsconfigPathsPlugin } from 'tsconfig-paths-webpack-plugin';
 import { readTsConfig } from '@nx/js';
 import { LicenseWebpackPlugin } from 'license-webpack-plugin';
-import TerserPlugin = require('terser-webpack-plugin');
-import nodeExternals = require('webpack-node-externals');
-import ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin');
 
 import { NormalizedWebpackExecutorOptions } from '../executors/webpack/schema';
 import { StatsJsonPlugin } from '../plugins/stats-json-plugin';
 import { createCopyPlugin } from './create-copy-plugin';
 import { GeneratePackageJsonPlugin } from '../plugins/generate-package-json-plugin';
 import { getOutputHashFormat } from './hash-format';
 import { NxWebpackPlugin } from './config';
+import { existsSync } from 'fs';
+import TerserPlugin = require('terser-webpack-plugin');
+import nodeExternals = require('webpack-node-externals');
+import ForkTsCheckerWebpackPlugin = require('fork-ts-checker-webpack-plugin');
+import browserslist = require('browserslist');
+
+const VALID_BROWSERSLIST_FILES = ['.browserslistrc', 'browserslist'];
+
+function getTerserEcmaVersion(projectRoot: string) {
+  let pathToBrowserslistFile = '';
+  for (const browserslistFile of VALID_BROWSERSLIST_FILES) {
+    const fullPathToFile = join(projectRoot, browserslistFile);
+    if (existsSync(fullPathToFile)) {
+      pathToBrowserslistFile = fullPathToFile;
+      break;
+    }
+  }
+
+  if (!pathToBrowserslistFile) {
+    return 2020;
+  }
+
+  const env = browserslist.loadConfig({ path: pathToBrowserslistFile });
+  const browsers = browserslist(env);
+  return browsers.includes('ie 11') ? 5 : 2020;
+}
 
 const IGNORED_WEBPACK_WARNINGS = [
   /The comment file/i,
@@ -213,7 +237,9 @@ export function withNx(pluginOptions?: WithNxOptions): NxWebpackPlugin {
                 parallel: true,
                 terserOptions: {
                   keep_classnames: true,
-                  ecma: 2020,
+                  ecma: getTerserEcmaVersion(
+                    join(options.root, options.projectRoot)
+                  ),
                   safari10: true,
                   format: {
                     ascii_only: true,