-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(nest): add v10 migrations for tsconfig & CacheModule (#17741)
- Loading branch information
1 parent
5fa6e48
commit 62651a5
Showing
4 changed files
with
384 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
134 changes: 134 additions & 0 deletions
134
packages/nest/src/migrations/update-16-4-0-cache-manager/nestjs-10-updates.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
import { | ||
Tree, | ||
addDependenciesToPackageJson, | ||
createProjectGraphAsync, | ||
formatFiles, | ||
getProjects, | ||
joinPathFragments, | ||
updateJson, | ||
visitNotIgnoredFiles, | ||
} from '@nx/devkit'; | ||
import { tsquery } from '@phenomnomnominal/tsquery'; | ||
import { | ||
ImportDeclaration, | ||
VariableStatement, | ||
ScriptTarget, | ||
isVariableStatement, | ||
} from 'typescript'; | ||
|
||
const JS_TS_FILE_MATCHER = /\.[jt]sx?$/; | ||
|
||
const importMatch = | ||
':matches(ImportDeclaration, VariableStatement):has(Identifier[name="CacheModule"], Identifier[name="CacheModule"]):has(StringLiteral[value="@nestjs/common"])'; | ||
|
||
export async function updateNestJs10(tree: Tree) { | ||
const nestProjects = await getNestProejcts(); | ||
if (nestProjects.length === 0) { | ||
return; | ||
} | ||
|
||
let installCacheModuleDeps = false; | ||
const projects = getProjects(tree); | ||
|
||
for (const projectName of nestProjects) { | ||
const projectConfig = projects.get(projectName); | ||
const tsConfig = | ||
projectConfig.targets?.build?.options?.tsConfig ?? | ||
joinPathFragments( | ||
projectConfig.root, | ||
projectConfig.projectType === 'application' | ||
? 'tsconfig.app.json' | ||
: 'tsconfig.lib.json' | ||
); | ||
|
||
if (tree.exists(tsConfig)) { | ||
updateTsConfigTarget(tree, tsConfig); | ||
} | ||
|
||
visitNotIgnoredFiles(tree, projectConfig.root, (filePath) => { | ||
if (!JS_TS_FILE_MATCHER.test(filePath)) { | ||
return; | ||
} | ||
|
||
installCacheModuleDeps = | ||
updateCacheManagerImport(tree, filePath) || installCacheModuleDeps; | ||
}); | ||
} | ||
|
||
await formatFiles(tree); | ||
|
||
return installCacheModuleDeps | ||
? addDependenciesToPackageJson( | ||
tree, | ||
{ | ||
'@nestjs/cache-manager': '^2.0.0', | ||
'cache-manager': '^5.2.3', | ||
}, | ||
{} | ||
) | ||
: () => {}; | ||
} | ||
|
||
async function getNestProejcts(): Promise<string[]> { | ||
const projectGraph = await createProjectGraphAsync(); | ||
|
||
return Object.entries(projectGraph.dependencies) | ||
.filter(([node, dep]) => | ||
dep.some( | ||
({ target }) => | ||
!projectGraph.externalNodes?.[node] && target === 'npm:@nestjs/common' | ||
) | ||
) | ||
.map(([projectName]) => projectName); | ||
} | ||
|
||
// change import { CacheModule } from '@nestjs/common'; | ||
// to import { CacheModule } from '@nestjs/cache-manager'; | ||
export function updateCacheManagerImport( | ||
tree: Tree, | ||
filePath: string | ||
): boolean { | ||
const content = tree.read(filePath, 'utf-8'); | ||
|
||
const updated = tsquery.replace( | ||
content, | ||
importMatch, | ||
|
||
(node: ImportDeclaration | VariableStatement) => { | ||
const text = node.getText(); | ||
return `${text.replace('CacheModule', '')}\n${ | ||
isVariableStatement(node) | ||
? "const { CacheModule } = require('@nestjs/cache-manager')" | ||
: "import { CacheModule } from '@nestjs/cache-manager';" | ||
}`; | ||
} | ||
); | ||
|
||
if (updated !== content) { | ||
tree.write(filePath, updated); | ||
return true; | ||
} | ||
} | ||
|
||
export function updateTsConfigTarget(tree: Tree, tsConfigPath: string) { | ||
updateJson(tree, tsConfigPath, (json) => { | ||
if (!json.compilerOptions.target) { | ||
return; | ||
} | ||
|
||
const normalizedTargetName = json.compilerOptions.target.toUpperCase(); | ||
// es6 isn't apart of the ScriptTarget enum but is a valid tsconfig target in json file | ||
const existingTarget = | ||
normalizedTargetName === 'ES6' | ||
? ScriptTarget.ES2015 | ||
: (ScriptTarget[normalizedTargetName] as unknown as ScriptTarget); | ||
|
||
if (existingTarget < ScriptTarget.ES2021) { | ||
json.compilerOptions.target = 'es2021'; | ||
} | ||
|
||
return json; | ||
}); | ||
} | ||
|
||
export default updateNestJs10; |
Oops, something went wrong.
62651a5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
nx-dev – ./
nx-dev-git-master-nrwl.vercel.app
nx-dev-nrwl.vercel.app
nx-five.vercel.app
nx.dev