chore(storybook): do not remove configurations even if empty

nrwl · Jun 20, 2024 · 5dfffbf · 5dfffbf
1 parent 3cdf28a
commit 5dfffbf
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 8 deletions.
diff --git a/packages/storybook/src/generators/convert-to-inferred/convert-to-inferred.spec.ts b/packages/storybook/src/generators/convert-to-inferred/convert-to-inferred.spec.ts
@@ -243,6 +243,9 @@ describe('Storybook - Convert To Inferred', () => {
             ],
           },
           "storybook": {
+            "configurations": {
+              "ci": {},
+            },
             "options": {
               "config-dir": ".storybook",
             },
@@ -311,6 +314,9 @@ describe('Storybook - Convert To Inferred', () => {
             ],
           },
           "storybook": {
+            "configurations": {
+              "ci": {},
+            },
             "options": {
               "config-dir": ".storybook",
             },
@@ -378,6 +384,9 @@ describe('Storybook - Convert To Inferred', () => {
             ],
           },
           "storybook": {
+            "configurations": {
+              "ci": {},
+            },
             "options": {
               "config-dir": ".storybook",
             },
@@ -413,6 +422,9 @@ describe('Storybook - Convert To Inferred', () => {
       expect(updatedProject.targets).toMatchInlineSnapshot(`
         {
           "build-storybook": {
+            "configurations": {
+              "dev": {},
+            },
             "options": {
               "config-dir": ".storybook",
               "output-dir": "../../dist/storybook/apps/app1",
@@ -426,6 +438,10 @@ describe('Storybook - Convert To Inferred', () => {
             ],
           },
           "storybook": {
+            "configurations": {
+              "ci": {},
+              "dev": {},
+            },
             "options": {
               "config-dir": ".storybook",
             },
@@ -534,6 +550,9 @@ describe('Storybook - Convert To Inferred', () => {
             ],
           },
           "storybook": {
+            "configurations": {
+              "ci": {},
+            },
             "options": {
               "config-dir": ".storybook",
             },
@@ -558,6 +577,9 @@ describe('Storybook - Convert To Inferred', () => {
             ],
           },
           "storybook": {
+            "configurations": {
+              "ci": {},
+            },
             "options": {
               "config-dir": ".storybook",
             },

diff --git a/packages/storybook/src/generators/convert-to-inferred/lib/build-post-target-transformer.ts b/packages/storybook/src/generators/convert-to-inferred/lib/build-post-target-transformer.ts
@@ -57,10 +57,6 @@ export function buildPostTargetTransformer(migrationLogs: AggregatedLog) {
           configValues[configurationName],
           migrationLogs
         );
-
-        if (Object.keys(configuration).length === 0) {
-          delete target.configurations[configurationName];
-        }
       }
 
       for (const configurationName in target.configurations) {

diff --git a/packages/storybook/src/generators/convert-to-inferred/lib/serve-post-target-transformer.ts b/packages/storybook/src/generators/convert-to-inferred/lib/serve-post-target-transformer.ts
@@ -57,10 +57,6 @@ export function servePostTargetTransformer(migrationLogs: AggregatedLog) {
           projectDetails.root,
           migrationLogs
         );
-
-        if (Object.keys(configuration).length === 0) {
-          delete target.configurations[configurationName];
-        }
       }
 
       if (Object.keys(target.configurations).length === 0) {