Skip to content

Commit

Permalink
fix(testing): pin cypress to 13.12.0 and re-enable skipped tests (#26751
Browse files Browse the repository at this point in the history
)
  • Loading branch information
Coly010 authored Jul 2, 2024
1 parent 8f65944 commit 5403639
Show file tree
Hide file tree
Showing 5 changed files with 37 additions and 21 deletions.
3 changes: 1 addition & 2 deletions e2e/cypress/src/cypress-legacy.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ import {

const TEN_MINS_MS = 600_000;

// TODO(colum): Re-enable after investigation into Cypress 13.12 and Xvfb
xdescribe('Cypress E2E Test runner (legacy)', () => {
describe('Cypress E2E Test runner (legacy)', () => {
beforeAll(() => {
newProject({ packages: ['@nx/angular', '@nx/react'] });
});
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
"convert-source-map": "^2.0.0",
"copy-webpack-plugin": "^10.2.4",
"css-minimizer-webpack-plugin": "^5.0.0",
"cypress": "13.9.0",
"cypress": "13.13.0",
"cytoscape": "^3.18.2",
"cytoscape-dagre": "^2.4.0",
"cytoscape-popper": "^2.0.0",
Expand Down
12 changes: 12 additions & 0 deletions packages/cypress/migrations.json
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,18 @@
"alwaysAddToPackageJson": false
}
}
},
"19.4.1": {
"version": "19.4.1-beta.0",
"requires": {
"cypress": "^13.0.0"
},
"packages": {
"cypress": {
"version": "^13.13.0",
"alwaysAddToPackageJson": false
}
}
}
}
}
2 changes: 1 addition & 1 deletion packages/cypress/src/utils/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ export const nxVersion = require('../../package.json').version;
export const eslintPluginCypressVersion = '^2.13.4';
export const typesNodeVersion = '18.16.9';
export const cypressViteDevServerVersion = '^2.2.1';
export const cypressVersion = '^13.8.0';
export const cypressVersion = '^13.13.0';
export const cypressWebpackVersion = '^3.8.0';
export const viteVersion = '~5.0.0';
export const htmlWebpackPluginVersion = '^5.5.0';
39 changes: 22 additions & 17 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5403639

Please sign in to comment.