fix(core): fix js test

nrwl · Apr 6, 2023 · 5184e36 · 5184e36
1 parent 45a06a4
commit 5184e36
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 23 deletions.
diff --git a/docs/generated/packages/web/documents/overview.md b/docs/generated/packages/web/documents/overview.md
@@ -41,9 +41,8 @@ To create a generic TypeScript library (i.e. non-framework specific), use the [`
 ```shell
 nx g @nrwl/js:lib my-new-lib
 
-# If you want the library to be buildable or publishable to npm
-nx g @nrwl/web:lib my-new-lib --buildable
-nx g @nrwl/web:lib my-new-lib \
+# If you want the library to be publishable to npm
+nx g @nrwl/js:lib my-new-lib \
 --publishable \
 --importPath=@myorg/my-new-lib
 ```

diff --git a/docs/shared/packages/web/web-plugin.md b/docs/shared/packages/web/web-plugin.md
@@ -41,9 +41,8 @@ To create a generic TypeScript library (i.e. non-framework specific), use the [`
 ```shell
 nx g @nrwl/js:lib my-new-lib
 
-# If you want the library to be buildable or publishable to npm
-nx g @nrwl/web:lib my-new-lib --buildable
-nx g @nrwl/web:lib my-new-lib \
+# If you want the library to be publishable to npm
+nx g @nrwl/js:lib my-new-lib \
 --publishable \
 --importPath=@myorg/my-new-lib
 ```

diff --git a/e2e/js/src/js.test.ts b/e2e/js/src/js.test.ts
@@ -151,17 +151,9 @@ export function ${lib}Wildcard() {
 
   it('should not be able to be built when it has no bundler', () => {
     const nonBuildable = uniq('buildable');
-
     runCLI(`generate @nrwl/js:lib ${nonBuildable} --bundler=none`);
 
-    const result = runCLI(`build ${nonBuildable}`);
-
-    expect(result).toContain(
-      `Compiling TypeScript files for project "${nonBuildable}"...`
-    );
-    expect(result).toContain(
-      `Done compiling TypeScript files for project "${nonBuildable}".`
-    );
+    expect(() => runCLI(`build ${nonBuildable}`)).toThrow();
 
     checkFilesDoNotExist(`dist/libs/${nonBuildable}/README.md`);
   });

diff --git a/e2e/nx-run/src/run.test.ts b/e2e/nx-run/src/run.test.ts
@@ -333,8 +333,8 @@ describe('Nx Running Tests', () => {
         mylib1 = uniq('mylib1');
         mylib2 = uniq('mylib1');
         runCLI(`generate @nrwl/web:app ${myapp}`);
-        runCLI(`generate @nrwl/web:lib ${mylib1} --buildable`);
-        runCLI(`generate @nrwl/web:lib ${mylib2} --buildable`);
+        runCLI(`generate @nrwl/js:lib ${mylib1}`);
+        runCLI(`generate @nrwl/js:lib ${mylib2}`);
 
         updateFile(
           `apps/${myapp}/src/main.ts`,

diff --git a/packages/web/src/generators/application/application.ts b/packages/web/src/generators/application/application.ts
@@ -176,12 +176,6 @@ function setDefaults(tree: Tree, options: NormalizedSchema) {
     e2eTestRunner: options.e2eTestRunner,
     ...nxJson.generators['@nrwl/web:application'],
   };
-  nxJson.generators['@nrwl/web:library'] = {
-    style: options.style,
-    linter: options.linter,
-    unitTestRunner: options.unitTestRunner,
-    ...nxJson.generators['@nrwl/web:library'],
-  };
   updateNxJson(tree, nxJson);
 }