fix(misc): remove segments from repo name that contain numerals when …

…creating a workspace Closes: #16360
nrwl · May 3, 2023 · 4aabf92 · 4aabf92
1 parent c2e8bf7
commit 4aabf92
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 7 deletions.
diff --git a/docs/generated/devkit/nx_devkit.md b/docs/generated/devkit/nx_devkit.md
@@ -992,9 +992,9 @@ Use this to expose a compatible Angular Builder
 
 #### Parameters
 
-| Name       | Type                                                            |
-| :--------- | :-------------------------------------------------------------- |
-| `executor` | [`Executor`](../../devkit/documents/nx_devkit#executor)<`any`\> |
+| Name       | Type                                                    |
+| :--------- | :------------------------------------------------------ |
+| `executor` | [`Executor`](../../devkit/documents/nx_devkit#executor) |
 
 #### Returns
 

diff --git a/docs/generated/packages/devkit/documents/nx_devkit.md b/docs/generated/packages/devkit/documents/nx_devkit.md
@@ -992,9 +992,9 @@ Use this to expose a compatible Angular Builder
 
 #### Parameters
 
-| Name       | Type                                                            |
-| :--------- | :-------------------------------------------------------------- |
-| `executor` | [`Executor`](../../devkit/documents/nx_devkit#executor)<`any`\> |
+| Name       | Type                                                    |
+| :--------- | :------------------------------------------------------ |
+| `executor` | [`Executor`](../../devkit/documents/nx_devkit#executor) |
 
 #### Returns
 

diff --git a/packages/workspace/src/generators/new/new.ts b/packages/workspace/src/generators/new/new.ts
@@ -118,11 +118,19 @@ function normalizeOptions(options: Schema): NormalizedSchema {
     ...options,
   };
 
-  normalized.name = names(options.name).fileName;
   if (!options.directory) {
     normalized.directory = options.name;
   }
 
+  // Repository name is the filename, but removes segments with numbers.
+  // This prevents errors where the path becomes the npm scope which is
+  // used as things like the selector for angular components, which are
+  // only allowed to start with a letter.
+  normalized.name = names(options.name)
+    .fileName.split('-')
+    .filter((segment) => /^[A-z]+$/.test(segment))
+    .join('-');
+
   const parsed = parsePresetName(options.preset);
 
   normalized.preset = parsed.package;