fix(core): nxComponentTestingPreset should not expose bundler option (#…

…23009)
nrwl · Apr 26, 2024 · 49af691 · 49af691
1 parent ac9ad35
commit 49af691
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/angular/plugins/component-testing.ts b/packages/angular/plugins/component-testing.ts
@@ -1,6 +1,6 @@
 import {
   nxBaseCypressPreset,
-  NxComponentTestingOptions,
+  NxComponentTestingPresetOptions,
 } from '@nx/cypress/plugins/cypress-preset';
 import {
   createExecutorContext,
@@ -45,7 +45,7 @@ import { gte } from 'semver';
  */
 export function nxComponentTestingPreset(
   pathToConfig: string,
-  options?: NxComponentTestingOptions
+  options?: NxComponentTestingPresetOptions
 ) {
   if (global.NX_GRAPH_CREATION) {
     // this is only used by plugins, so we don't need the component testing

diff --git a/packages/cypress/plugins/cypress-preset.ts b/packages/cypress/plugins/cypress-preset.ts
@@ -34,6 +34,11 @@ export interface NxComponentTestingOptions {
   compiler?: 'swc' | 'babel';
 }
 
+// The bundler is only used while generating the component testing configuration
+// It cannot be changed after the configuration is generated
+export interface NxComponentTestingPresetOptions
+  extends Omit<NxComponentTestingOptions, 'bundler'> {}
+
 export function nxBaseCypressPreset(
   pathToConfig: string,
   options?: { testingType: 'component' | 'e2e' }