fix(core): generate npm preset correctly (#18164)

nrwl · Jul 18, 2023 · 36cd6b0 · 36cd6b0 · vercel · Jul 18, 2023
1 parent 21bf6cd
commit 36cd6b0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/e2e/workspace-create-npm/src/create-nx-workspace-npm.test.ts b/e2e/workspace-create-npm/src/create-nx-workspace-npm.test.ts
@@ -37,6 +37,17 @@ describe('create-nx-workspace --preset=npm', () => {
     cleanupProject({ skipReset: true });
   });
 
+  it('should setup package-based workspace', () => {
+    const packageJson = readJson('package.json');
+    expect(packageJson.dependencies).toEqual({});
+
+    if (getSelectedPackageManager() === 'pnpm') {
+      checkFilesExist('pnpm-workspace.yaml');
+    } else {
+      expect(packageJson.workspaces).toEqual(['packages/*']);
+    }
+  });
+
   it('should add angular application', () => {
     packageInstall('@nx/angular', wsName);
     const appName = uniq('my-app');

diff --git a/packages/create-nx-workspace/bin/create-nx-workspace.ts b/packages/create-nx-workspace/bin/create-nx-workspace.ts
@@ -412,7 +412,6 @@ async function determineNoneOptions(
     } else {
       preset = Preset.NPM;
     }
-    preset = workspaceType === 'standalone' ? Preset.TsStandalone : Preset.TS;
   }
 
   if (parsedArgs.js !== undefined) {