Skip to content

Commit

Permalink
fix(testing): only add atomizer label for parent atomizer task (#26740)
Browse files Browse the repository at this point in the history
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Atomizer is shown for all split targets

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Atomizer is shown for only the parent atomizer target.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
FrozenPandaz authored Jun 27, 2024
1 parent 5364e27 commit 336d371
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 8 deletions.
1 change: 0 additions & 1 deletion packages/cypress/src/plugins/plugin.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,6 @@ describe('@nx/cypress/plugin', () => {
],
},
},
"nonAtomizedTarget": "e2e",
"technologies": [
"cypress",
],
Expand Down
1 change: 0 additions & 1 deletion packages/cypress/src/plugins/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ async function buildCypressTargets(
metadata: {
technologies: ['cypress'],
description: `Runs Cypress Tests in ${relativeSpecFilePath} in CI`,
nonAtomizedTarget: options.targetName,
help: {
command: `${pmc.exec} cypress run --help`,
example: {
Expand Down
1 change: 0 additions & 1 deletion packages/jest/src/plugins/plugin.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,6 @@ describe('@nx/jest/plugin', () => {
},
},
},
"nonAtomizedTarget": "test",
"technologies": [
"jest",
],
Expand Down
1 change: 0 additions & 1 deletion packages/jest/src/plugins/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,6 @@ async function buildJestTargets(
metadata: {
technologies: ['jest'],
description: `Run Jest Tests in ${relativePath}`,
nonAtomizedTarget: options.targetName,
help: {
command: `${pmc.exec} jest --help`,
example: {
Expand Down
2 changes: 0 additions & 2 deletions packages/playwright/src/plugins/plugin.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,6 @@ describe('@nx/playwright/plugin', () => {
},
},
},
"nonAtomizedTarget": "e2e",
"technologies": [
"playwright",
],
Expand Down Expand Up @@ -384,7 +383,6 @@ describe('@nx/playwright/plugin', () => {
},
},
},
"nonAtomizedTarget": "e2e",
"technologies": [
"playwright",
],
Expand Down
1 change: 0 additions & 1 deletion packages/playwright/src/plugins/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ async function buildPlaywrightTargets(
metadata: {
technologies: ['playwright'],
description: `Runs Playwright Tests in ${relativeSpecFilePath} in CI`,
nonAtomizedTarget: options.targetName,
help: {
command: `${pmc.exec} playwright test --help`,
example: {
Expand Down
2 changes: 1 addition & 1 deletion typedoc-theme/jest.config.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const nxPreset = require('@nx/jest/preset').default;
const nxPreset = require('../node_modules/@nx/jest/preset').default;

/* eslint-disable */
export default {
Expand Down

0 comments on commit 336d371

Please sign in to comment.