-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(core): support yarn berry patches in pruned lock file (#15993)
- Loading branch information
Showing
4 changed files
with
79 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1037,6 +1037,7 @@ __metadata: | |
"@nrwl/devkit": 15.0.13 | ||
eslint-plugin-disable-autofix: "npm:@mattlewis92/[email protected]" | ||
postgres: "https://github.com/charsleysa/postgres.git#commit=3b1a01b2da3e2fafb1a79006f838eff11a8de3cb" | ||
typescript: 4.8.4 | ||
yargs: 17.6.2 | ||
devDependencies: | ||
react: 18.2.0 | ||
|
@@ -1073,6 +1074,26 @@ __metadata: | |
languageName: node | ||
linkType: hard | ||
"typescript@npm:4.8.4": | ||
version: 4.8.4 | ||
resolution: "typescript@npm:4.8.4" | ||
bin: | ||
tsc: bin/tsc | ||
tsserver: bin/tsserver | ||
checksum: ee000bc26848147ad423b581bd250075662a354d84f0e06eb76d3b892328d8d4440b7487b5a83e851b12b255f55d71835b008a66cbf8f255a11e4400159237db | ||
languageName: node | ||
linkType: hard | ||
"typescript@patch:[email protected]#~builtin<compat/typescript>": | ||
version: 4.8.4 | ||
resolution: "typescript@patch:typescript@npm%3A4.8.4#~builtin<compat/typescript>::version=4.8.4&hash=23ec76" | ||
bin: | ||
tsc: bin/tsc | ||
tsserver: bin/tsserver | ||
checksum: ab417a2f398380c90a6cf5a5f74badd17866adf57f1165617d6a551f059c3ba0a3e4da0d147b3ac5681db9ac76a303c5876394b13b3de75fdd5b1eaa06181c9d | ||
languageName: node | ||
linkType: hard | ||
"uri-js@npm:^4.2.2": | ||
version: 4.4.1 | ||
resolution: "uri-js@npm:4.4.1" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1074,6 +1074,26 @@ __metadata: | |
languageName: node | ||
linkType: hard | ||
"typescript@npm:4.8.4": | ||
version: 4.8.4 | ||
resolution: "typescript@npm:4.8.4" | ||
bin: | ||
tsc: bin/tsc | ||
tsserver: bin/tsserver | ||
checksum: ee000bc26848147ad423b581bd250075662a354d84f0e06eb76d3b892328d8d4440b7487b5a83e851b12b255f55d71835b008a66cbf8f255a11e4400159237db | ||
languageName: node | ||
linkType: hard | ||
"typescript@patch:[email protected]#~builtin<compat/typescript>": | ||
version: 4.8.4 | ||
resolution: "typescript@patch:typescript@npm%3A4.8.4#~builtin<compat/typescript>::version=4.8.4&hash=23ec76" | ||
bin: | ||
tsc: bin/tsc | ||
tsserver: bin/tsserver | ||
checksum: ab417a2f398380c90a6cf5a5f74badd17866adf57f1165617d6a551f059c3ba0a3e4da0d147b3ac5681db9ac76a303c5876394b13b3de75fdd5b1eaa06181c9d | ||
languageName: node | ||
linkType: hard | ||
"uri-js@npm:^4.2.2": | ||
version: 4.4.1 | ||
resolution: "uri-js@npm:4.4.1" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -369,7 +369,7 @@ describe('yarn LockFile utility', () => { | |
const builder = new ProjectGraphBuilder(); | ||
parseYarnLockfile(berryLockFile, builder); | ||
const graph = builder.getUpdatedProjectGraph(); | ||
expect(Object.keys(graph.externalNodes).length).toEqual(128); //124 hoisted | ||
expect(Object.keys(graph.externalNodes).length).toEqual(129); //124 hoisted | ||
|
||
expect(graph.externalNodes['npm:minimatch']).toMatchInlineSnapshot(` | ||
Object { | ||
|
@@ -433,6 +433,7 @@ describe('yarn LockFile utility', () => { | |
'npm:@mattlewis92/[email protected]', | ||
postgres: | ||
'https://github.com/charsleysa/postgres.git#commit=3b1a01b2da3e2fafb1a79006f838eff11a8de3cb', | ||
typescript: '4.8.4', | ||
yargs: '17.6.2', | ||
}, | ||
devDependencies: { | ||
|
@@ -930,7 +931,7 @@ __metadata: | |
const prunedGraph = pruneProjectGraph(graph, prunedPackageJson); | ||
expect(stringifyYarnLockfile(prunedGraph, lockFile, prunedPackageJson)) | ||
.toMatchInlineSnapshot(` | ||
"# This file was generated by Nx. Do not edit this file directly | ||
"# This file is generated by running \\"yarn install\\" inside your project. | ||
# Manual changes might be lost - proceed with caution! | ||
__metadata: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30f993e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
nx-dev – ./
nx-dev-git-master-nrwl.vercel.app
nx-dev-nrwl.vercel.app
nx-five.vercel.app
nx.dev