fix(core): project inference plugins should be ran when reading proje…

…ct configuration (#18630)
nrwl · Aug 15, 2023 · 2760026 · 2760026 · vercel · Aug 15, 2023
1 parent 11249e9
commit 2760026
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/packages/nx/src/config/workspaces.ts b/packages/nx/src/config/workspaces.ts
@@ -1,6 +1,7 @@
 import { dirname, join } from 'path';
 import { workspaceRoot } from '../utils/workspace-root';
 import { readJsonFile } from '../utils/fileutils';
+import { getNxRequirePaths } from '../utils/installation-directory';
 import { loadNxPlugins, loadNxPluginsSync } from '../utils/nx-plugin';
 
 import type { NxJsonConfiguration } from './nx-json';
@@ -43,7 +44,11 @@ export class Workspaces {
       buildProjectsConfigurationsFromProjectPathsAndPlugins(
         nxJson,
         projectPaths,
-        loadNxPluginsSync(),
+        loadNxPluginsSync(
+          nxJson.plugins,
+          getNxRequirePaths(this.root),
+          this.root
+        ),
         this.root
       ).projects;
     if (
@@ -59,10 +64,7 @@ export class Workspaces {
     }
     this.cachedProjectsConfig = {
       version: 2,
-      projects: this.mergeTargetDefaultsIntoProjectDescriptions(
-        projectsConfigurations,
-        nxJson
-      ),
+      projects: projectsConfigurations,
     };
     return this.cachedProjectsConfig;
   }

diff --git a/packages/nx/src/utils/nx-plugin.ts b/packages/nx/src/utils/nx-plugin.ts
@@ -209,7 +209,7 @@ function loadNxPluginSync(moduleName: string, paths: string[], root: string) {
  * @deprecated Use loadNxPlugins instead.
  */
 export function loadNxPluginsSync(
-  plugins?: string[],
+  plugins: string[],
   paths = getNxRequirePaths(),
   root = workspaceRoot
 ): (NxPluginV2 & Pick<NxPluginV1, 'processProjectGraph'>)[] {
@@ -240,7 +240,7 @@ export function loadNxPluginsSync(
 }
 
 export async function loadNxPlugins(
-  plugins?: string[],
+  plugins: string[],
   paths = getNxRequirePaths(),
   root = workspaceRoot
 ): Promise<(NxPluginV2 & Pick<NxPluginV1, 'processProjectGraph'>)[]> {