fix(core): ensure createPackageJson does not override existing config (…

…#17471)
nrwl · Jun 12, 2023 · 2653809 · 2653809 · vercel · Jun 12, 2023
1 parent 81a499a
commit 2653809
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/packages/js/src/utils/package-json/update-package-json.spec.ts b/packages/js/src/utils/package-json/update-package-json.spec.ts
@@ -434,11 +434,15 @@ describe('updatePackageJson', () => {
         "dependencies": {
           "external1": "~1.0.0",
           "external2": "^4.0.0",
+          "lib2": "^0.0.1",
+        },
+        "devDependencies": {
+          "jest": "27",
         },
         "main": "./main.js",
         "name": "@org/lib1",
         "types": "./main.d.ts",
-        "version": "0.0.1",
+        "version": "0.0.3",
       }
     `);
   });

diff --git a/packages/nx/src/plugins/js/package-json/create-package-json.ts b/packages/nx/src/plugins/js/package-json/create-package-json.ts
@@ -15,6 +15,7 @@ import {
 } from '../../../hasher/task-hasher';
 import { readNxJson } from '../../../config/configuration';
 import { readProjectFileMapCache } from '../../../project-graph/nx-deps-cache';
+import { join } from 'path';
 
 interface NpmDeps {
   readonly dependencies: Record<string, string>;
@@ -80,11 +81,14 @@ export function createPackageJson(
     name: projectName,
     version: '0.0.1',
   };
-  if (existsSync(`${graph.nodes[projectName].data.root}/package.json`)) {
+  const projectPackageJsonPath = join(
+    options.root || workspaceRoot,
+    projectNode.data.root,
+    'package.json'
+  );
+  if (existsSync(projectPackageJsonPath)) {
     try {
-      packageJson = readJsonFile(
-        `${graph.nodes[projectName].data.root}/package.json`
-      );
+      packageJson = readJsonFile(projectPackageJsonPath);
       // for standalone projects we don't want to include all the root dependencies
       if (graph.nodes[projectName].data.root === '.') {
         // TODO: We should probably think more on this - Nx can't always