Skip to content

Commit

Permalink
fix(bundling): remove the vue options from vite gen
Browse files Browse the repository at this point in the history
Remove the Vuejs options from the vite generator, since we're not providing much
  • Loading branch information
mandarini committed Nov 17, 2022
1 parent c0deca8 commit 1c1b6db
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 11 deletions.
2 changes: 1 addition & 1 deletion docs/generated/packages/vite.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"uiFramework": {
"type": "string",
"description": "UI Framework to use for Vite.",
"enum": ["react", "vue3", "vue3-jsx"],
"enum": ["react", "none"],
"default": "react",
"x-prompt": "What UI framework plugin should Vite use?"
}
Expand Down
8 changes: 0 additions & 8 deletions packages/vite/src/generators/init/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,6 @@ function checkDependenciesInstalled(host: Tree, schema: Schema) {
devDependencies['@vitejs/plugin-react'] = vitePluginReactVersion;
}

if (schema.uiFramework === 'vue3') {
devDependencies['@vitejs/plugin-vue'] = vitePluginReactVersion;
}

if (schema.uiFramework === 'vue3-jsx') {
devDependencies['@vitejs/plugin-vue-jsx'] = vitePluginReactVersion;
}

return addDependenciesToPackageJson(host, dependencies, devDependencies);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/vite/src/generators/init/schema.d.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
export interface Schema {
uiFramework: 'react' | 'vue3' | 'vue3-jsx';
uiFramework: 'react' | 'none';
}
2 changes: 1 addition & 1 deletion packages/vite/src/generators/init/schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"uiFramework": {
"type": "string",
"description": "UI Framework to use for Vite.",
"enum": ["react", "vue3", "vue3-jsx"],
"enum": ["react", "none"],
"default": "react",
"x-prompt": "What UI framework plugin should Vite use?"
}
Expand Down

0 comments on commit 1c1b6db

Please sign in to comment.