fix(react): mf should consider ssl when setting remote urls #16989 (#…

…17746)
nrwl · Jun 23, 2023 · 1891add · 1891add · vercel · Jun 23, 2023
1 parent 61faa55
commit 1891add
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/angular/src/utils/mf/utils.ts b/packages/angular/src/utils/mf/utils.ts
@@ -58,7 +58,9 @@ export function getFunctionDeterminateRemoteUrl(isServer: boolean = false) {
       );
     }
 
-    const host = serveTarget.options?.host ?? 'http://localhost';
+    const host =
+      serveTarget.options?.host ??
+      `http${serveTarget.options.ssl ? 's' : ''}://localhost`;
     const port = serveTarget.options?.port ?? 4201;
     return `${
       host.endsWith('/') ? host.slice(0, -1) : host

diff --git a/packages/react/src/module-federation/utils.ts b/packages/react/src/module-federation/utils.ts
@@ -31,7 +31,9 @@ export function getFunctionDeterminateRemoteUrl(isServer: boolean = false) {
       );
     }
 
-    const host = serveTarget.options?.host ?? 'http://localhost';
+    const host =
+      serveTarget.options?.host ??
+      `http${serveTarget.options.ssl ? 's' : ''}://localhost`;
     const port = serveTarget.options?.port ?? 4201;
     return `${
       host.endsWith('/') ? host.slice(0, -1) : host