fix(bundling): add skipTypeField back for rollup executor (#17629)

nrwl · Jun 22, 2023 · 162b144 · 162b144 · vercel · Jun 22, 2023
1 parent 1e8de7a
commit 162b144
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/docs/generated/packages/rollup/executors/rollup.json b/docs/generated/packages/rollup/executors/rollup.json
@@ -169,6 +169,11 @@
         "type": "boolean",
         "description": "Whether to skip TypeScript type checking.",
         "default": false
+      },
+      "skipTypeField": {
+        "type": "boolean",
+        "description": "Prevents 'type' field from being added to compiled package.json file. Use this if you are having an issue with this field.",
+        "default": false
       }
     },
     "required": ["tsConfig", "main", "outputPath"],

diff --git a/packages/rollup/src/executors/rollup/lib/update-package-json.ts b/packages/rollup/src/executors/rollup/lib/update-package-json.ts
@@ -45,8 +45,9 @@ export function updatePackageJson(
     packageJson.main = './index.cjs';
     exports['.']['require'] = './index.cjs';
   }
-
-  packageJson.type = options.format.includes('esm') ? 'module' : 'commonjs';
+  if (!options.skipTypeField) {
+    packageJson.type = options.format.includes('esm') ? 'module' : 'commonjs';
+  }
 
   // Support for older TS versions < 4.5
   packageJson.types = types;

diff --git a/packages/rollup/src/executors/rollup/schema.d.ts b/packages/rollup/src/executors/rollup/schema.d.ts
@@ -33,4 +33,5 @@ export interface RollupExecutorOptions {
   generateExportsField?: boolean;
   skipTypeCheck?: boolean;
   babelUpwardRootMode?: boolean;
+  skipTypeField?: boolean;
 }
diff --git a/packages/rollup/src/executors/rollup/schema.json b/packages/rollup/src/executors/rollup/schema.json
@@ -156,6 +156,11 @@
       "type": "boolean",
       "description": "Whether to skip TypeScript type checking.",
       "default": false
+    },
+    "skipTypeField": {
+      "type": "boolean",
+      "description": "Prevents 'type' field from being added to compiled package.json file. Use this if you are having an issue with this field.",
+      "default": false
     }
   },
   "required": ["tsConfig", "main", "outputPath"],