feat(testing): add --strict flag for jest-preset-angular test env opts (

#16467) (cherry picked from commit 50ad516)
nrwl · May 9, 2023 · 0d90bc8 · 0d90bc8
1 parent f6b05e4
commit 0d90bc8
Show file tree

Hide file tree

Showing 4 changed files with 45 additions and 3 deletions.
diff --git a/packages/angular/src/generators/application/lib/add-unit-test-runner.ts b/packages/angular/src/generators/application/lib/add-unit-test-runner.ts
@@ -1,4 +1,4 @@
-import type { Tree } from '@nx/devkit';
+import { Tree, joinPathFragments } from '@nx/devkit';
 import type { NormalizedSchema } from './normalized-schema';
 
 import { jestProjectGenerator } from '@nx/jest';
@@ -15,5 +15,24 @@ export async function addUnitTestRunner(host: Tree, options: NormalizedSchema) {
       skipPackageJson: options.skipPackageJson,
       skipFormat: true,
     });
+    const setupFile = joinPathFragments(
+      options.appProjectRoot,
+      'src',
+      'test-setup.ts'
+    );
+    if (options.strict && host.exists(setupFile)) {
+      const contents = host.read(setupFile, 'utf-8');
+      host.write(
+        setupFile,
+        `// @ts-expect-error https://thymikee.github.io/jest-preset-angular/docs/getting-started/test-environment
+globalThis.ngJest = {
+  testEnvironmentOptions: {
+    errorOnUnknownElements: true,
+    errorOnUnknownProperties: true,
+  },
+};
+${contents}`
+      );
+    }
   }
 }
diff --git a/packages/angular/src/generators/library/library.ts b/packages/angular/src/generators/library/library.ts
@@ -134,6 +134,25 @@ async function addUnitTestRunner(
       skipFormat: true,
       skipPackageJson: options.skipPackageJson,
     });
+    const setupFile = joinPathFragments(
+      options.projectRoot,
+      'src',
+      'test-setup.ts'
+    );
+    if (options.strict && host.exists(setupFile)) {
+      const contents = host.read(setupFile, 'utf-8');
+      host.write(
+        setupFile,
+        `// @ts-expect-error https://thymikee.github.io/jest-preset-angular/docs/getting-started/test-environment
+globalThis.ngJest = {
+  testEnvironmentOptions: {
+    errorOnUnknownElements: true,
+    errorOnUnknownProperties: true,
+  },
+};
+${contents}`
+      );
+    }
   }
 }
 

diff --git a/packages/jest/src/generators/jest-project/__snapshots__/jest-project.spec.ts.snap b/packages/jest/src/generators/jest-project/__snapshots__/jest-project.spec.ts.snap
@@ -81,7 +81,7 @@ export default {
 "
 `;
 
-exports[`jestProject should generate files 1`] = `
+exports[`jestProject should generate files 2`] = `
 "/* eslint-disable */
 export default {
   displayName: 'lib1',

diff --git a/packages/jest/src/generators/jest-project/jest-project.spec.ts b/packages/jest/src/generators/jest-project/jest-project.spec.ts
@@ -50,7 +50,11 @@ describe('jestProject', () => {
       project: 'lib1',
       setupFile: 'angular',
     } as JestProjectSchema);
-    expect(tree.exists('libs/lib1/src/test-setup.ts')).toBeTruthy();
+    expect(tree.read('libs/lib1/src/test-setup.ts', 'utf-8'))
+      .toMatchInlineSnapshot(`
+      "import 'jest-preset-angular/setup-jest';
+      "
+    `);
     expect(tree.exists('libs/lib1/jest.config.ts')).toBeTruthy();
     expect(tree.exists('libs/lib1/tsconfig.spec.json')).toBeTruthy();
     expect(tree.read('libs/lib1/jest.config.ts', 'utf-8')).toMatchSnapshot();