Skip to content

Commit

Permalink
cleanup(angular): replace old util with devkit util and remove "ignor…
Browse files Browse the repository at this point in the history
…e" dependency (#27126)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
leosvelperez authored Jul 26, 2024
1 parent 45c458e commit 09b0b38
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 38 deletions.
1 change: 0 additions & 1 deletion packages/angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
"@typescript-eslint/type-utils": "^7.16.0",
"chalk": "^4.1.0",
"find-cache-dir": "^3.3.2",
"ignore": "^5.0.4",
"magic-string": "~0.30.2",
"minimatch": "9.0.3",
"semver": "^7.5.3",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import type { Identifier, SourceFile, Statement } from 'typescript';
import { getTsSourceFile } from '../../../utils/nx-devkit/ast-utils';
import type { EntryPoint } from './entry-point';
import { getModuleDeclaredComponents } from './module-info';
import { getAllFilesRecursivelyFromDir } from './tree-utilities';

let tsModule: typeof import('typescript');
let tsquery: typeof import('@phenomnomnominal/tsquery').tsquery;
Expand Down Expand Up @@ -242,7 +241,12 @@ function getComponentInfoFromDir(
): ComponentInfo {
let path = null;
let componentFileName = null;
const componentImportPathChildren = getAllFilesRecursivelyFromDir(tree, dir);

const componentImportPathChildren: string[] = [];
visitNotIgnoredFiles(tree, dir, (filePath) => {
componentImportPathChildren.push(filePath);
});

for (const candidateFile of componentImportPathChildren) {
if (candidateFile.endsWith('.ts')) {
const content = tree.read(candidateFile, 'utf-8');
Expand Down

This file was deleted.

0 comments on commit 09b0b38

Please sign in to comment.