fix: remove extra tsconfig.spec.json entry in app tsconfig.json

nrwl · Nov 20, 2020 · 9de074e · 9de074e
1 parent aa22905
commit 9de074e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/e2e/react-native-e2e/tests/react-native.test.ts b/e2e/react-native-e2e/tests/react-native.test.ts
@@ -40,6 +40,8 @@ test('sync npm dependencies for autolink', async () => {
   updateFile(join('package.json'), (content) => {
     const json = JSON.parse(content);
     json.dependencies['react-native-image-picker'] = '1.0.0';
+    json.dependencies['react-native-gesture-handler'] = '1.0.0';
+    json.dependencies['react-native-safe-area-contex'] = '1.0.0';
     return JSON.stringify(json, null, 2);
   });
   // Add import for Nx to pick up

diff --git a/packages/react-native/src/builders/sync-deps/sync-deps.impl.ts b/packages/react-native/src/builders/sync-deps/sync-deps.impl.ts
@@ -27,14 +27,19 @@ export function syncDeps(
   const npmDeps = findAllNpmDependencies(graph, projectName);
   const packageJsonPath = join(projectRoot, 'package.json');
   const packageJson = readJsonFile(packageJsonPath);
-  const newDeps = include?.split(',') || [];
+  const newDeps = [];
+  const includeDeps = include?.split(',');
   let updated = false;
 
   if (!packageJson.dependencies) {
     packageJson.dependencies = {};
     updated = true;
   }
 
+  if (includeDeps) {
+    npmDeps.push(...includeDeps);
+  }
+
   npmDeps.forEach((dep) => {
     if (!packageJson.dependencies[dep]) {
       packageJson.dependencies[dep] = '*';

diff --git a/packages/react-native/src/schematics/application/files/app/tsconfig.json.template b/packages/react-native/src/schematics/application/files/app/tsconfig.json.template
@@ -14,9 +14,6 @@
   "references": [
     {
       "path": "./tsconfig.app.json"
-    },
-    {
-      "path": "./tsconfig.spec.json"
     }
   ],
   "exclude": [