fix(nx-ignore): include enhanced-resolve for nx repo and potentially other repos using it #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud Report
CI is running/has finished running commands for commit bbaee12. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
jaysoo
force-pushed
the
fix/nx-ignore-enhanced-resolve
branch
2 times, most recently
from
51a1ded to
40ceaee
Compare
jaysoo
commented
May 3, 2024
| @@ -106,7 +106,9 @@ async function main() { | |||
| const graphJsonPath = join(tmpdir(), '.nx-affected-graph.json'); | |||
| try { | |||
| execSync( | |||
| `npx nx affected:graph --base=${baseSha} --head=${headSha} --file=${graphJsonPath}`, | |||
| `npx nx affected:graph --base=${baseSha} --head=${headSha} --file=${graphJsonPath}${ | |||
| isVerbose ? ' --verbose' : '' | |||
There was a problem hiding this comment.
Pass --verbose to Nx so we can see the graph errors.
jaysoo
commented
May 3, 2024
| @@ -115,7 +117,7 @@ async function main() { | |||
| if (e.stdout) console.error(e.stdout.toString()); | |||
| if (e.stderr) console.error(e.stderr.toString()); | |||
| exitWithoutBuild( | |||
| `🛑 - Build cancelled due to the error above, you may need to use --additional-packages option if using Nx plugins to infer targets e.g. Project Crystal (Hint: commit with "[nx deploy]" to force deployment if necessary)` | |||
| `🛑 - Build cancelled due to the error above. You may need to use --additional-packages option if using Nx plugins to infer targets e.g. Project Crystal. (Hint: commit with "[nx deploy]" to force deployment if necessary)` | |||
ndcunningham
approved these changes
May 3, 2024
…other repos using it
jaysoo
force-pushed
the
fix/nx-ignore-enhanced-resolve
branch
from
40ceaee to
bbaee12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's somewhat of an edge case because Nx repo has a patched jest resolver that requires
enhanced-resolve.