Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix): support remix v2 #350

Merged
merged 2 commits into from
Dec 6, 2023
Merged

feat(remix): support remix v2 #350

merged 2 commits into from
Dec 6, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Nov 22, 2023

  • Add support for Remix v2
  • Remove v1 generation code (Meta, ErrorBoundary)
  • Update test setup for correct unit testing
  • Update config files to correctly use ESM

BLOCKED
There seems to be an issue in Remix's CLI for running remix dev where it cannot find remix-serve.

@Coly010 Coly010 self-assigned this Nov 22, 2023
@Coly010 Coly010 requested a review from jaysoo November 22, 2023 16:34
@Coly010 Coly010 force-pushed the remix/v2-support branch 2 times, most recently from 531567e to e65e707 Compare November 30, 2023 15:18
Copy link

nx-cloud bot commented Nov 30, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4f42494. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


⌛ The following targets are in progress

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@Coly010 Coly010 force-pushed the remix/v2-support branch 4 times, most recently from c04d520 to baabfda Compare December 5, 2023 13:33
@Coly010 Coly010 marked this pull request as ready for review December 5, 2023 13:34
@Coly010 Coly010 requested a review from ndcunningham December 5, 2023 13:34
@Coly010 Coly010 force-pushed the remix/v2-support branch 2 times, most recently from 637de2e to 4951649 Compare December 5, 2023 16:05
@jaysoo jaysoo enabled auto-merge (squash) December 6, 2023 19:00
@jaysoo jaysoo merged commit bd5f012 into nrwl:main Dec 6, 2023
7 checks passed
@Coly010 Coly010 deleted the remix/v2-support branch December 6, 2023 20:19
@Coly010 Coly010 restored the remix/v2-support branch December 8, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants