Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rspack): add generatePackageJson plugin #341

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

travtarr
Copy link
Contributor

@travtarr travtarr commented Oct 1, 2023

Closes #226

@travtarr travtarr force-pushed the tt-add-rspack-generate-packagejson branch from f900f66 to df6fbb0 Compare October 1, 2023 19:05
@travtarr
Copy link
Contributor Author

travtarr commented Oct 1, 2023

The e2e tests pass and I've successfully ran the builds when linking this to all my other Nest projects utilizing this rspack executor.

@kodeine
Copy link

kodeine commented Oct 24, 2023

@mandarini whenever you get time, can we please merge? thank you

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving @travtarr @kodeine , but please can you rebase with latest main?

@nx-cloud
Copy link

nx-cloud bot commented Oct 24, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e7c52b7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


⌛ The following target is in progress

✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@travtarr travtarr force-pushed the tt-add-rspack-generate-packagejson branch from df6fbb0 to e7c52b7 Compare October 24, 2023 15:06
@travtarr
Copy link
Contributor Author

I'm approving @travtarr @kodeine , but please can you rebase with latest main?

It's been rebased, thanks!

@kodeine
Copy link

kodeine commented Oct 30, 2023

@mandarini sorry for the tag :) would really appreciate if we can merge this, thank you for all the work you do!

@mandarini mandarini merged commit 9e87815 into nrwl:main Oct 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add webpack's generatePackageJson option to rspack's project configuration
3 participants