fix: affected-project selection (#551)

nrwl · Feb 22, 2019 · 0e310b9 · 0e310b9
1 parent a47c438
commit 0e310b9
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 11 deletions.
diff --git a/apps/vscode/src/app/tree-item/workspace-route.ts b/apps/vscode/src/app/tree-item/workspace-route.ts
@@ -93,22 +93,28 @@ export function getWorkspaceRoute(
   workspaceDef: WorkspaceDefinition | undefined,
   workspaceRouteTitle: WorkspaceRouteTitle = 'Projects'
 ): string {
+  const workspacePath = workspaceDef
+    ? workspaceDef.path
+    : workspace.workspaceFolders && workspace.workspaceFolders[0].uri.fsPath;
+
   switch (workspaceRouteTitle) {
     case 'Workspaces':
       return 'workspaces';
     case 'Connect':
       return 'connect';
+    case 'Affected Projects':
+      if (workspacePath) {
+        return `workspace/${encodeURIComponent(
+          workspacePath
+        )}/connect/affected-projects`;
+      } else {
+        return 'workspaces';
+      }
     case 'Projects':
     case 'Extensions':
     case 'Tasks':
-    case 'Affected Projects':
     case 'Settings':
     case 'Generate':
-      const workspacePath = workspaceDef
-        ? workspaceDef.path
-        : workspace.workspaceFolders &&
-          workspace.workspaceFolders[0].uri.fsPath;
-
       if (workspacePath) {
         return `workspace/${encodeURIComponent(
           workspacePath

diff --git a/libs/feature-workspaces/src/lib/feature-workspaces.module.ts b/libs/feature-workspaces/src/lib/feature-workspaces.module.ts
@@ -64,10 +64,12 @@ export const workspaceRoutes: Route[] = [
         path: 'extensions',
         children: extensionsRoutes
       },
-      // TODO: Remove connect routes from workspace after electron redesign.
       {
         path: 'connect',
-        children: connectRootRoutes
+        children: [
+          ...connectWorkspaceRoutes,
+          ...connectRootRoutes // TODO: Remove connect routes from workspace after electron redesign.
+        ]
       },
       {
         data: { state: 'generate' },
@@ -76,8 +78,7 @@ export const workspaceRoutes: Route[] = [
       },
       { data: { state: 'tasks' }, path: 'tasks', children: runRoutes },
       // TODO: Remove settings routes from workspace after electron redesign.
-      { path: 'settings', children: settingsRoutes },
-      ...connectWorkspaceRoutes
+      { path: 'settings', children: settingsRoutes }
     ]
   }
 ];

diff --git a/libs/feature-workspaces/src/lib/workspace/workspace.component.ts b/libs/feature-workspaces/src/lib/workspace/workspace.component.ts
@@ -212,7 +212,7 @@ export class WorkspaceComponent implements OnInit, OnDestroy {
           this.routes[0],
           {
             icon: 'timeline',
-            url: 'affected-projects',
+            url: 'connect/affected-projects',
             title: 'Affected Projects'
           },
           ...this.routes.slice(1)