fix: set GitHub env variables on frontend deployment

nrwl · Oct 6, 2024 · d95900e · d95900e
1 parent 843229a
commit d95900e
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/charts/nx-cloud/Chart.yaml b/charts/nx-cloud/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: nx-cloud
 description: Nx Cloud Helm Chart
 type: application
-version: 0.15.12
+version: 0.15.13
 maintainers:
   - name: nx
     url: "https://nx.app/"

diff --git a/charts/nx-cloud/templates/nx-cloud-frontend-deployment.yaml b/charts/nx-cloud/templates/nx-cloud-frontend-deployment.yaml
@@ -80,8 +80,22 @@ spec:
                   name: {{ .name }}
                   key: {{ .githubPrivateKey }}
             {{- end }}
+            {{- if .githubAppClientId }}
+            - name: NX_CLOUD_GITHUB_APP_CLIENT_ID
+              valueFrom:
+                secretKeyRef:
+                  name: {{ .name }}
+                  key: {{ .githubAppClientId }}
+            {{- end }}
+            {{- if .githubAppClientSecret }}
+            - name: NX_CLOUD_GITHUB_APP_CLIENT_SECRET
+              valueFrom:
+                secretKeyRef:
+                  name: {{ .name }}
+                  key: {{ .githubAppClientSecret }}
+            {{- end }}
             {{- if .githubAppId }}
-            - name: NX_CLOUD_GITHUB_APP_ID
+            - name: NX_CLOUD_GITHUB_APP_APP_ID
               valueFrom:
                 secretKeyRef:
                   name: {{ .name }}