Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I swear, saying HI yesterday was not to get this MR in ;)
Im not 100% positive this is correct, but it fixes.
Prior to this change, every time I would connect to the AP to do the configure, I would get and IP of
169.254.128.129
Some painful googling, it looks like this is something that has creeped into the underlying ESP codebase.
espressif/esp-idf#6108
I finally found this reference, and doing this swap was the only thing that would allow the client to get a proper IP repeatably
esp8266/Arduino#8326