Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to upload and ingest ingestData from snapshot (SOFIE-3553) #1307

Open
wants to merge 2 commits into
base: release52
Choose a base branch
from

Conversation

nytamin
Copy link
Contributor

@nytamin nytamin commented Oct 31, 2024

About the Contributor

This pull request is posted on behalf of the NRK

Type of Contribution

This is a:

Code improvement / DevX improvement

Current Behavior

It is only possible to upload snapshots directly, which means that whats uploaded is equivalent to the original Rundown.

New Behavior

Now one can choose to "Ingest from Snapshot", where Sofie will only read the ingestData from the snapshot and pipe it through the current blueprints to recreate the Rundown(s) within.

This is useful for blueprint development or troubleshooting.

image

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This PR affects snapshot restoring.

Time Frame

Not urgent, but we would like to get this merged into the in-development release

Other Information

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 4.61538% with 62 lines in your changes missing coverage. Please review.

Project coverage is 57.92%. Comparing base (ea7cece) to head (428e95d).
Report is 181 commits behind head on release52.

Files with missing lines Patch % Lines
meteor/server/api/snapshot.ts 4.61% 62 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           release52    #1307   +/-   ##
==========================================
  Coverage      57.91%   57.92%           
==========================================
  Files            525      525           
  Lines          84945    84989   +44     
  Branches        4438     4448   +10     
==========================================
+ Hits           49200    49229   +29     
- Misses         35689    35704   +15     
  Partials          56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nytamin nytamin changed the title Add user option to upload and ingest ingestData from snapshot Add option to upload and ingest ingestData from snapshot (SOFIE-3553) Oct 31, 2024
@nytamin nytamin marked this pull request as ready for review November 14, 2024 09:15
@nytamin nytamin requested a review from a team as a code owner November 14, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants