Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Core scroll target element #640

Merged
merged 10 commits into from
Aug 10, 2022
Merged

Core scroll target element #640

merged 10 commits into from
Aug 10, 2022

Conversation

skjalgepalg
Copy link
Collaborator

Work in progress to address #288

@skjalgepalg skjalgepalg self-assigned this Feb 1, 2022
@skjalgepalg
Copy link
Collaborator Author

  • Expanded parsePoint to support elements
  • Added JSDocs to the parts of core-scroll pertaining to this issue
  • Added tests to core-scroll
  • Return a promise with the target of scroll on complete, enabling less guesswork as to when animation is complete
  • Added element to docs for scroll method signature

@skjalgepalg skjalgepalg marked this pull request as ready for review February 4, 2022 13:04
pingrid
pingrid approved these changes Apr 19, 2022
View reviewed changes
Copy link

@pingrid pingrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bra ut 😄 👍

@skjalgepalg skjalgepalg requested a review from artgos August 2, 2022 10:27
@skjalgepalg
Copy link
Collaborator Author

Published prerelease for testing @nrk/[email protected]

@skjalgepalg skjalgepalg merged commit 39edee5 into master Aug 10, 2022
@skjalgepalg skjalgepalg deleted the core-scroll-target-element branch August 10, 2022 10:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pingrid pingrid pingrid approved these changes

@eirikbacker eirikbacker eirikbacker approved these changes

@artgos artgos Awaiting requested review from artgos

Assignees

@skjalgepalg skjalgepalg

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skjalgepalg @eirikbacker @pingrid