core-dialog: Server rendered core dialog includes stringified onDialogToggle prop

[esseb]

Example server rendered markup:

<core-dialog-react class="modal-dialog__dialog" onDialogToggle="function handleDialogClose() {
  // Some logic I've removed here
  props.onClose();
}" aria-label="React dialog">
 ...
</core-dialog-react>

This causes a React hydration warning because of a difference in my handleDialogClose function between server and client due to code minification etc.

Fails on master. Regressed between feb16c6 and 0f41aab.

[htor]

thanks for this! looking into it..

[htor]

closed by #265