core-dialog: Unique tag name triggers React hydration warning

[esseb]

I get this warning when using @nrk/[email protected] in react16.8.6 in dev mode:

react-dom.development.js:506 Warning: Expected server HTML to contain a matching <coredialog-jw688k8f156> in <div>.

The React documentation about hydration says that "you should treat mismatches as bugs and fix them"

As far as I can tell from the source this is because the element's tag name is a generated UUID based on the current time, which will naturally differ between server and client.

Is there an option I can use to ensure this unique tag name is identical between the server and the client? The generic tag name core-dialog with no UUID would be enough for my purposes so I would be fine with a solution where I could disable the unique tag.

[eirikbacker]

Not good enough for other users, but we can solve this with version-number instead :) @htor

[esseb]

Something like a version number would be fine :)

[htor]

@esseb can you confirm this works in latest master? thanks

[esseb]

@htor latest master (3b864c8) looks fine.

The custom element is now rendered with the tag name core-dialog-react on both server and client. No warning from React (other than #261 which is unrelated).

Closing.