boards: nrf54h20: refactor MRAM board level code #2115
+26
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DK" This reverts commit 38f2104. Signed-off-by: Gerard Marull-Paretas <[email protected]>
NordicBuilder
requested review from
anangl,
jaz1-nordic,
kl-cruz,
krish2718,
magp-nordic,
masz-nordic,
nika-nordic,
nordic-krch,
rajb9,
sachinthegreen,
srkanordic and
udaynordic
57300
reviewed
Oct 15, 2024
| @@ -38,8 +38,6 @@ config NRFS | |||
| bool "nRF Services Support" | |||
| select NRFS_LOCAL_DOMAIN if (SOC_NRF54H20_CPUAPP || SOC_NRF54H20_CPURAD || SOC_NRF9280_CPUAPP || SOC_NRF9280_CPURAD) | |||
| depends on HAS_NRFS | |||
| depends on !MISRA_SANE | |||
There was a problem hiding this comment.
Do you know if this is addressed? #1856 (comment)
(if not, maybe it should've been taken upstream)
There was a problem hiding this comment.
If that's the case then this needs to be upstreamed.
There was a problem hiding this comment.
I've tested with the option and I'm able to compile successfully, maybe it's not a problem anymore?
Turn off suspending MRAM for nRF54H20 SoC. This change is required so sections of code depending on critical timings will not have unacceptable latency. Signed-off-by: Jan Zyczkowski <[email protected]> Signed-off-by: Gerard Marull-Paretas <[email protected]> (cherry picked from commit 58284ff) (cherry picked from commit 9b6cae8) (cherry picked from commit 2c2f60d)
gmarull
force-pushed
the
54h20-no-board-code
branch
from
f356b66
to
2ec1e6f
Compare
57300
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move code to soc level, also refactor it a bit. This makes sure this setting is applied regardless of the board.