driver: flash: Network core flash driver #13917

sigvartmh · 2024-02-08T09:19:44Z

Flash driver for interacting with network core's flash from the application core. This utilizes IPC and NRF_RPC to do flash commands in the network core.

NordicBuilder · 2024-02-15T19:59:40Z

Test specification

CI/Jenkins/NRF

Integration Platforms

CI/Jenkins/integration

Test Module	File based changes	Manually selected	West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2024-02-15T20:32:25Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

drivers/flash/Kconfig

drivers/flash/flash_rpc/flash_rpc_common.c

drivers/flash/flash_rpc/flash_rpc_controller.c

nordicjm · 2024-02-20T09:12:15Z

I do wonder if we really need this here, or could it go upstream to zephyr instead?

sigvartmh · 2024-02-20T13:43:44Z

I do wonder if we really need this here, or could it go upstream to Zephyr instead?

Does it make sense for anything upstream to use this? I wouldn't mind putting it upstream; I wonder if it would be accepted. All this is just a workaround because the application core cannot access network core flash while being the driver of updates.

carlescufi

I think you should consider using a light-weight combination:

Stop using nrf_ipc
Use icmsg as a backend for the IPC service
Use something super light-weight like nrfs does (check with @Rafal-Nordic)

If that doesn't work to reduce flash footprint then we should just use this PR as-is.

Great work by the way!

nvlsianpu · 2024-02-28T13:06:23Z

@carlescufi
Thank for your comments.

We are pursuit to optimize the footprint. This will be done (most probably) by using own serialization layer instead of zcbor and tweaks the configuration. As the result I expected something which will be possible in boot-time and in application-running time (two separate instances, separated in execution time, each with own configuration).

Discussed with Andrzej, optimization will be tackled later

SeppoTakalo · 2024-02-29T10:17:55Z

Dropping from 2.6.0 as there was no approvals before RC1.

nvlsianpu

I will

nvlsianpu · 2024-04-13T08:45:33Z

drivers/flash/flash_rpc/flash_rpc_host.c

+static const struct device *const flash_controller =
+	DEVICE_DT_GET_OR_NULL(DT_CHOSEN(zephyr_flash_controller));


I need to go back there - VNFD should allow full access in boot stage (B0N's VNFD instance) and limits access in application run-time stage ( networking stack VNFD instance). Maybe we should do that in follow-up patch.

nvlsianpu

I really appreciate how this code legible is.
Just one nit for help info.
I think access control might be introduced in follow-up PR.

drivers/flash/Kconfig

de-nordic

Looks OK. Once comment left.

drivers/flash/Kconfig

Flash driver for interacting with network core's flash from the application core. This utilizes IPC and NRF_RPC to controll flash commands in the network core. Signed-off-by: Sigvart Hovland <[email protected]>

de-nordic · 2024-04-17T11:51:50Z

drivers/flash/Kconfig

+	select NRF_RPC
+	select NRF_RPC_CBOR
+	select FLASH
+


Unneeded empty line?

NordicBuilder · 2024-04-17T12:32:51Z

Memory footprint analysis revealed the following potential issues

sample.matter.template.release[nrf7002dk_nrf5340_cpuapp]: ROM size increased by 1440[B] in comparison to the main branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf5340dk_nrf5340_cpuapp]: ROM size increased by 1448[B] in comparison to the main branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)
sample.matter.template.release[nrf52840dk_nrf52840]: ROM size increased by 1452[B] in comparison to the main branch. - link (cc: @kkasperczyk-no @ArekBalysNordic @markaj-nordic)

Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-13917/35)

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 8, 2024

nvlsianpu self-requested a review February 8, 2024 09:37

nvlsianpu added this to the 2.6.0 milestone Feb 8, 2024

sigvartmh self-assigned this Feb 8, 2024

sigvartmh force-pushed the nrf53_rpc_flash_driver branch from 8830c59 to 10addfa Compare February 8, 2024 14:09

sigvartmh requested review from de-nordic and michalek-no February 12, 2024 11:47

sigvartmh force-pushed the nrf53_rpc_flash_driver branch from 10addfa to 50854ef Compare February 13, 2024 12:00

nvlsianpu requested a review from KAGA164 February 14, 2024 08:47

sigvartmh force-pushed the nrf53_rpc_flash_driver branch 3 times, most recently from 1952ca8 to 180d09d Compare February 15, 2024 19:58

sigvartmh marked this pull request as ready for review February 15, 2024 19:59

sigvartmh requested a review from anangl as a code owner February 15, 2024 19:59

sigvartmh force-pushed the nrf53_rpc_flash_driver branch 7 times, most recently from ee9c08f to 1050136 Compare February 19, 2024 09:15

de-nordic requested a review from nordicjm February 19, 2024 14:05

sigvartmh force-pushed the nrf53_rpc_flash_driver branch 2 times, most recently from 8bbf11d to 1c5b5d4 Compare February 19, 2024 17:47

nordicjm reviewed Feb 20, 2024

View reviewed changes

sigvartmh force-pushed the nrf53_rpc_flash_driver branch from 1c5b5d4 to 8ead7ee Compare February 20, 2024 13:41

sigvartmh force-pushed the nrf53_rpc_flash_driver branch 3 times, most recently from 5014a5b to 665c00c Compare February 26, 2024 11:49

carlescufi previously requested changes Feb 27, 2024

View reviewed changes

sigvartmh force-pushed the nrf53_rpc_flash_driver branch from 665c00c to d134667 Compare February 28, 2024 03:10

carlescufi requested a review from doki-nordic February 28, 2024 13:38

sigvartmh force-pushed the nrf53_rpc_flash_driver branch 5 times, most recently from 9489d5d to 6c690bb Compare February 29, 2024 09:55

SeppoTakalo removed this from the 2.6.0 milestone Feb 29, 2024

sigvartmh force-pushed the nrf53_rpc_flash_driver branch 3 times, most recently from 2d55d7b to 6a856e4 Compare March 6, 2024 06:41

nvlsianpu reviewed Apr 13, 2024

View reviewed changes

sigvartmh force-pushed the nrf53_rpc_flash_driver branch 2 times, most recently from ffe5a9b to b02088d Compare April 15, 2024 07:14

nvlsianpu approved these changes Apr 16, 2024

View reviewed changes

drivers/flash/Kconfig Outdated Show resolved Hide resolved

de-nordic approved these changes Apr 16, 2024

View reviewed changes

drivers/flash/Kconfig Outdated Show resolved Hide resolved

sigvartmh force-pushed the nrf53_rpc_flash_driver branch from b02088d to 472432e Compare April 17, 2024 11:44

driver: flash: Network core flash driver

39225f3

Flash driver for interacting with network core's flash from the application core. This utilizes IPC and NRF_RPC to controll flash commands in the network core. Signed-off-by: Sigvart Hovland <[email protected]>

sigvartmh force-pushed the nrf53_rpc_flash_driver branch from 472432e to 39225f3 Compare April 17, 2024 11:45

de-nordic reviewed Apr 17, 2024

View reviewed changes

drivers/flash/Kconfig

select NRF_RPC

select NRF_RPC_CBOR

select FLASH

Copy link

Contributor

de-nordic Apr 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded empty line?

cvinayak merged commit a087201 into nrfconnect:main Apr 17, 2024
13 checks passed

de-nordic mentioned this pull request Aug 9, 2024

[RFC] Support image sources other than flash mcu-tools/mcuboot#2031

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

driver: flash: Network core flash driver #13917

driver: flash: Network core flash driver #13917

sigvartmh commented Feb 8, 2024

NordicBuilder commented Feb 15, 2024 •

edited

Loading

NordicBuilder commented Feb 15, 2024

nordicjm commented Feb 20, 2024

sigvartmh commented Feb 20, 2024

carlescufi left a comment •

edited

Loading

nvlsianpu commented Feb 28, 2024

SeppoTakalo commented Feb 29, 2024

nvlsianpu left a comment

nvlsianpu Apr 13, 2024

nvlsianpu left a comment

de-nordic left a comment

de-nordic Apr 17, 2024

NordicBuilder commented Apr 17, 2024

		static const struct device *const flash_controller =
		DEVICE_DT_GET_OR_NULL(DT_CHOSEN(zephyr_flash_controller));

driver: flash: Network core flash driver #13917

driver: flash: Network core flash driver #13917

Conversation

sigvartmh commented Feb 8, 2024

NordicBuilder commented Feb 15, 2024 • edited Loading

Test specification

CI/Jenkins/NRF

CI/Jenkins/integration

NordicBuilder commented Feb 15, 2024

nordicjm commented Feb 20, 2024

sigvartmh commented Feb 20, 2024

carlescufi left a comment • edited Loading

Choose a reason for hiding this comment

nvlsianpu commented Feb 28, 2024

SeppoTakalo commented Feb 29, 2024

nvlsianpu left a comment

Choose a reason for hiding this comment

nvlsianpu Apr 13, 2024

Choose a reason for hiding this comment

nvlsianpu left a comment

Choose a reason for hiding this comment

de-nordic left a comment

Choose a reason for hiding this comment

de-nordic Apr 17, 2024

Choose a reason for hiding this comment

NordicBuilder commented Apr 17, 2024

Memory footprint analysis revealed the following potential issues

NordicBuilder commented Feb 15, 2024 •

edited

Loading

carlescufi left a comment •

edited

Loading