[Maps] set filter.meta.key to geoFieldName so query passes filterMatc…

…hesIndex when ignoreFilterIfFieldNotInIndex is true (elastic#56692) * [Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex * remove unused variable Co-authored-by: Elastic Machine <[email protected]>
nreese · Feb 10, 2020 · ec1724c · ec1724c
1 parent 27b7f50
commit ec1724c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/src/plugins/data/public/query/filter_manager/lib/mappers/map_spatial_filter.test.ts b/src/plugins/data/public/query/filter_manager/lib/mappers/map_spatial_filter.test.ts
@@ -24,6 +24,7 @@ describe('mapSpatialFilter()', () => {
   test('should return the key for matching multi polygon filter', async () => {
     const filter = {
       meta: {
+        key: 'location',
         alias: 'my spatial filter',
         type: esFilters.FILTERS.SPATIAL_FILTER,
       } as esFilters.FilterMeta,
@@ -41,14 +42,15 @@ describe('mapSpatialFilter()', () => {
     } as esFilters.Filter;
     const result = mapSpatialFilter(filter);
 
-    expect(result).toHaveProperty('key', 'query');
+    expect(result).toHaveProperty('key', 'location');
     expect(result).toHaveProperty('value', '');
     expect(result).toHaveProperty('type', esFilters.FILTERS.SPATIAL_FILTER);
   });
 
   test('should return the key for matching polygon filter', async () => {
     const filter = {
       meta: {
+        key: 'location',
         alias: 'my spatial filter',
         type: esFilters.FILTERS.SPATIAL_FILTER,
       } as esFilters.FilterMeta,
@@ -58,14 +60,15 @@ describe('mapSpatialFilter()', () => {
     } as esFilters.Filter;
     const result = mapSpatialFilter(filter);
 
-    expect(result).toHaveProperty('key', 'geo_polygon');
+    expect(result).toHaveProperty('key', 'location');
     expect(result).toHaveProperty('value', '');
     expect(result).toHaveProperty('type', esFilters.FILTERS.SPATIAL_FILTER);
   });
 
   test('should return undefined for none matching', async done => {
     const filter = {
       meta: {
+        key: 'location',
         alias: 'my spatial filter',
       } as esFilters.FilterMeta,
       geo_polygon: {

diff --git a/src/plugins/data/public/query/filter_manager/lib/mappers/map_spatial_filter.ts b/src/plugins/data/public/query/filter_manager/lib/mappers/map_spatial_filter.ts
@@ -20,18 +20,14 @@ import { esFilters } from '../../../../../common';
 
 // Use mapSpatialFilter mapper to avoid bloated meta with value and params for spatial filters.
 export const mapSpatialFilter = (filter: esFilters.Filter) => {
-  const metaProperty = /(^\$|meta)/;
-  const key = Object.keys(filter).find(item => {
-    return !item.match(metaProperty);
-  });
   if (
-    key &&
     filter.meta &&
+    filter.meta.key &&
     filter.meta.alias &&
     filter.meta.type === esFilters.FILTERS.SPATIAL_FILTER
   ) {
     return {
-      key,
+      key: filter.meta.key,
       type: filter.meta.type,
       value: '',
     };

diff --git a/x-pack/legacy/plugins/maps/public/elasticsearch_geo_utils.js b/x-pack/legacy/plugins/maps/public/elasticsearch_geo_utils.js
@@ -297,6 +297,7 @@ function createGeometryFilterWithMeta({
     type: SPATIAL_FILTER_TYPE,
     negate: false,
     index: indexPatternId,
+    key: geoFieldName,
     alias: `${geoFieldName} ${relationLabel} ${geometryLabel}`,
   };