fix: Use include-workspace-root
for /main
in Post Dependabot
#462
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
steps.metadata.outputs.directory
is set to/main
, not/
, whenpackage.json
is at the root of the repository. I suspect addingtarget-branch
todependabot.yml
(#330) added amain
segment to Dependabot PR branch names, which changed the value ofsteps.metadata.outputs.directory
.By fixing this issue, we shouldn't need to routinely use stafftools to fix up template-oss Dependabot PRs. 🤞🏼
I couldn't quickly find a
bump @npmcli/template-oss
Dependabot PR for a workspace to inspectsteps.metadata.outputs.directory
and fix workspaces support. If that's important, we may want to either enable Dependabot fornpm/cli
or create a separatetemplate-oss-test
repo. It's not clear if Dependabot will create a PR forworkspace/test-workspace
upon our next release.Example Dependabot PR branch names
The first PR updates just
@npmcli/template-oss
. The second updates multiple dependencies including@npmcli/template-oss
.dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0
/main
dependabot/npm_and_yarn/main/dependency-updates-4de8b5bfcf
/
References
Failed "Post Dependabot" run: https://github.com/npm/agent/actions/runs/9963674341/job/27530225303
Fix manually tested here: npm/agent@ef85b08
branchNameToDirectoryName
Bug report: dependabot/fetch-metadata#540